Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Add release action #73

Closed
wants to merge 7 commits into from
Closed

Add release action #73

wants to merge 7 commits into from

Conversation

frankharkins
Copy link
Member

@frankharkins frankharkins commented Aug 11, 2023

Adds an action to upload notebooks to directus database.

  • Each notebook folder can now contain a directus_info.json which contains a link to the directus database, plus the lesson ID.
  • The release.py script compresses the folder and uploads it. You can test this out locally using
    python release.py notebooks/**/*.ipynb
  • I've added an action to do this automatically on pushing to dev/v3.x

@frankharkins frankharkins marked this pull request as ready for review August 11, 2023 11:08
Copy link
Contributor

@vabarbosa vabarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankharkins this is great! thank you!

a couple comments

  • what about the case of new content being added? is it expected that the first time the content needs to be updated manually?
  • if and when the URLs change it would require finding/changing every info file and updating accordingly. would it make sense to have the URLs hardcoded in the release.py and just choose the appropriate one based on the env? that way only one place would need to be updated when URL changes.

@frankharkins
Copy link
Member Author

@vabarbosa thanks!

what about the case of new content being added? is it expected that the first time the content needs to be updated manually?

For MVP yes, with a view to maybe using a TOC file in the future. I'll update the documentation.

if and when the URLs change it would require finding/changing every info file and updating accordingly. would it make sense to have the URLs hardcoded in the release.py and just choose the appropriate one based on the env? that way only one place would need to be updated when URL changes.

That's a much better idea – thanks :)

@frankharkins
Copy link
Member Author

Gonna move this to its own repo

@frankharkins frankharkins deleted the fh-release-action branch August 17, 2023 13:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants