Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(worker/polymarket): add polymarket worker #540

Merged
merged 26 commits into from
Sep 13, 2024

Conversation

FrankLi123
Copy link
Contributor

@FrankLi123 FrankLi123 commented Sep 12, 2024

Summary

This PR includes necessary changes for adding a polymarket worker.

Checklist

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@FrankLi123 FrankLi123 changed the base branch from main to worker-dev September 12, 2024 09:02
@FrankLi123 FrankLi123 self-assigned this Sep 12, 2024
@FrankLi123 FrankLi123 linked an issue Sep 12, 2024 that may be closed by this pull request
1 task
Copy link
Member

@pseudoyu pseudoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add more code comments in the worker logics

@pseudoyu
Copy link
Member

should add networkToWorker map in config api

https://github.com/RSS3-Network/Node/blob/main/internal/node/component/info/network_config.go#L228

@pseudoyu
Copy link
Member

LGTM.

But should test the data using dev environment before releasing.

@FrankLi123 FrankLi123 merged commit 4c52081 into worker-dev Sep 13, 2024
5 checks passed
@FrankLi123 FrankLi123 deleted the feat/add-polymarket-worker branch September 13, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

polymarket
2 participants