Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pymem json #828

Merged
merged 4 commits into from
Aug 18, 2024
Merged

Pymem json #828

merged 4 commits into from
Aug 18, 2024

Conversation

RainerKuemmerle
Copy link
Owner

No description provided.

JSON should be enough as human readable and easy to interchange format
Dropping cereal library which seems not well maintained.
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 10 lines in your changes missing coverage. Please review.

Project coverage is 65.67%. Comparing base (0a44a47) to head (24d1ffd).
Report is 4 commits behind head on pymem.

Files Patch % Lines
g2o/core/io/io_binary.cpp 50.00% 5 Missing ⚠️
g2o/core/io/io_json.cpp 54.54% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            pymem     #828      +/-   ##
==========================================
- Coverage   65.75%   65.67%   -0.09%     
==========================================
  Files         343      342       -1     
  Lines       13402    13383      -19     
  Branches     1318     1317       -1     
==========================================
- Hits         8813     8789      -24     
- Misses       4202     4207       +5     
  Partials      387      387              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainerKuemmerle RainerKuemmerle merged commit 0b21e74 into pymem Aug 18, 2024
7 checks passed
@RainerKuemmerle RainerKuemmerle deleted the pymem-json branch August 18, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant