Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subtest Pair can use any order #4513

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

subtest Pair can use any order #4513

wants to merge 1 commit into from

Conversation

JJ
Copy link
Contributor

@JJ JJ commented Sep 4, 2024

The problem

The original text says that Pairs need to be in a certain order. That's not really true; tested the alternative order and it works anyway.

Solution provided

Changed example to reflect that too.

Changed example to reflect that too.
@coke
Copy link
Collaborator

coke commented Sep 4, 2024

Thanks for the catch! My one concern is that roast doesn't seem to test this variant of subtest. Part of resolving this PR this should include at least a ticket in roast with the omission. Rakudo seems to have added this in rakudo/rakudo@e239f6e, back in 2016, so I think we're safe in assuming it's intentional.

Copy link
Collaborator

@coke coke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we show both variants of Pair examples?

@JJ
Copy link
Contributor Author

JJ commented Sep 4, 2024

Thanks for the catch! My one concern is that roast doesn't seem to test this variant of subtest. Part of resolving this PR this should include at least a ticket in roast with the omission. Rakudo seems to have added this in rakudo/rakudo@e239f6e, back in 2016, so I think we're safe in assuming it's intentional.

Well, Test is not raku so testing should be made in rakudo/rakudo, right?. Which begs the question, is Test tested? I haven't found any subdirectory that seems to do so in the t directory.

@JJ
Copy link
Contributor Author

JJ commented Sep 4, 2024

Can we show both variants of Pair examples?

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants