Skip to content

Commit

Permalink
Use eu time format for de locale
Browse files Browse the repository at this point in the history
  • Loading branch information
relja-rasa committed Oct 18, 2023
1 parent a47ffb9 commit 7acfcd7
Show file tree
Hide file tree
Showing 2 changed files with 62 additions and 0 deletions.
23 changes: 23 additions & 0 deletions rasa/nlu/extractors/duckling_entity_extractor.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from rasa.nlu.extractors.extractor import EntityExtractorMixin
from rasa.shared.nlu.training_data.message import Message
import rasa.shared.utils.io
from datetime import datetime


logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -204,3 +205,25 @@ def process(self, messages: List[Message]) -> List[Message]:
)

return messages

class GermanDatetimeEntityExtractor(DucklingEntityExtractor):
def __init__(self, config: Dict[Text, Any]) -> None:
super().__init__(config)
def _duckling_parse(self, text: Text, reference_time: int) -> List[Dict[Text, Any]]:
if self.component_config.get("locale") == "de":
original_result = super()._duckling_parse(text, reference_time)
modified_result = self.modify_datetime_format(original_result)
return modified_result

return super()._duckling_parse(text, reference_time)

def modify_datetime_format(self, original_result):
for entity in original_result:
if "value" in entity and entity["dim"] == "time":
try:
original_datetime = datetime.fromisoformat(entity["value"])
formatted_datetime = original_datetime.strftime("%d-%m-%Y")
entity["value"] = formatted_datetime
except ValueError:
print(ValueError)
return original_result
39 changes: 39 additions & 0 deletions rasa/nlu/extractors/test_german_date_extractor.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import unittest
from duckling_entity_extractor import GermanDatetimeEntityExtractor

class TestGermanDatetimeExtractor(unittest.TestCase):
def setUp(self):
config = {"locale": "de"}
self.extractor = GermanDatetimeEntityExtractor(config)

self.config_en = {"locale": "en"}
self.extractor_en = GermanDatetimeEntityExtractor(self.config_en)

def test_modify_datetime_format(self):
original_result = [
{"dim": "time", "value": "2023-10-20"},
]

modified_result = self.extractor.modify_datetime_format(original_result)

expected_result = [
{"dim": "time", "value": "20-10-2023"},
]

self.assertEqual(modified_result, expected_result)

def test_modify_datetime_format_en(self):
original_result = [
{"dim": "time", "value": "2023-10-20T14:30:00.000Z"}
]

modified_result = self.extractor_en.modify_datetime_format(original_result)

expected_result = [
{"dim": "time", "value": "2023-10-20T14:30:00.000Z"}
]

self.assertEqual(modified_result, expected_result)

if __name__ == "__main__":
unittest.main()

0 comments on commit 7acfcd7

Please sign in to comment.