Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs cleanup components #12865
Docs cleanup components #12865
Changes from 6 commits
86724df
c4ad2b8
9601417
88201e2
eba07cb
57828f1
bb944cc
21f0db2
e479e9c
74d845e
9f84a0c
4098485
1c7fcea
23da906
5052c54
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for me it makes more sense to keep this under the Components section. Can you explain your reasoning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thinking is that components is under 'key concepts' which to me implies things you should understand as a Rasa user. IMO these pieces are not 'key' but rather advanced topics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My worry is that we put things under the Reference section and it becomes a catch-all section for everything that doesn't fit with Key concept or the sections we added.
Because one key selling point of Rasa is to allow for customisation and configuration, it could actually make sense to have a section for building advanced assistants for pushing the boundaries of what Rasa bakes in by default. WDYT? I would see that section between "Operating at scale" and "Reference".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that idea, especially if we can use it as a place to articulate what we consider the public facing API and what things are internal and you shouldn't touch unless you want to make your own life hard. But clearly outside the scope of this PR. Happy to put this back in key concepts for now