Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for NLG change - [ENG 501] #12875

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Conversation

varunshankar
Copy link
Contributor

@varunshankar varunshankar commented Sep 26, 2023

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@varunshankar varunshankar requested a review from a team as a code owner September 26, 2023 11:58
@varunshankar varunshankar self-assigned this Sep 26, 2023
@varunshankar varunshankar requested review from tmbo and twerkmeister and removed request for a team September 29, 2023 11:35
@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 5 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 49 Code Smells

0.0% 0.0% Coverage
1.0% 1.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@varunshankar varunshankar merged commit 1a66128 into dm2 Oct 10, 2023
101 checks passed
@varunshankar varunshankar deleted the ENG-501-test-nlg-changes-1 branch October 10, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants