Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to show that the excess turns are discarded when creating the readable tracker #12924

Closed

Conversation

varunshankar
Copy link
Contributor

@varunshankar varunshankar commented Oct 18, 2023

Proposed changes:

  • Add tests to show that the excess turns are discarded when creating the readable tracker (without specifying the max_turns arg)

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

Copy link
Contributor

@twerkmeister twerkmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks already pretty good. However, I would suggest adding the max turns and also the other default arguments explicitly to call of tracker_as_readable_transcript in the test. We want to test that the method does what we think it does. Right now, we also test that the default arguments have specific values and the test is gonna break if that default changes, although the method might still be perfectly fine

@djcowley djcowley self-requested a review October 25, 2023 09:37
@dakshvar22 dakshvar22 removed their request for review October 26, 2023 07:30
@varunshankar varunshankar deleted the ENG-XYZ-add-test-tracker-as-readable-transcript branch October 27, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants