Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unicode handling in JSON serialization for SQLTrackerStore #12990

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

droogg
Copy link

@droogg droogg commented Jan 10, 2024

This pull request updates the JSON serialization within the SQLTrackerStore to preserve non-ASCII characters such as Cyrillic script. By setting ensure_ascii=False in json.dumps, the data is now stored in its original representation, allowing for proper storage and retrieval of non-ASCII characters. This change addresses issues with Unicode encoding in the database, ensuring that intent and action names containing Cyrillic characters are correctly represented.

Proposed changes:

  • Set ensure_ascii=False in json.dumps to preserve non-ASCII characters in the database.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

This commit updates the JSON serialization within the SQLTrackerStore to preserve non-ASCII characters such as Cyrillic script. By setting ensure_ascii=False in json.dumps, the data is now stored in its original representation, allowing for proper storage and retrieval of non-ASCII characters. This change addresses issues with Unicode encoding in the database, ensuring that intent and action names containing Cyrillic characters are correctly represented.
@droogg droogg requested a review from a team as a code owner January 10, 2024 07:17
@CLAassistant
Copy link

CLAassistant commented Jan 10, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants