feat: Pre-release patches toggle #1785

kitadai31 · 2024-03-25T07:37:44Z

Add a toggle for pre-release patches to the alternative source settings.
Closes: #821

This PR also fixes an problem where pre-release Integrations are being used when using alternate sources.
At this time, Patches are referring GitHubAPI#getLatestPatchesRelease() that doesn't include pre-releases, but Integrations are referring GitHubAPI#getLatestRelease() that includes pre-releases.
This problem actually caused patched apps to crash recently in crimera/piko patches (an alternative source) when they released a pre-releases.
(Actually, this is the main motivation)

getLatestReleaseFile() in github_api.dart was removed because it's unused

Ushie · 2024-03-25T11:10:22Z

Why limit it to alternative sources?

You can pass ?dev=true to achieve the same with the ReVanced API

oSumAtrIX · 2024-03-25T12:34:05Z

Are changelogs/updates considered as well?

@Ushie I am not sure but are queries ignored by cache on CloudFlare? Because then, using the dev query has no effect.

kitadai31 · 2024-03-25T17:16:33Z

I already tried ?dev=true at ReVanced API, but it didn't effect.
https://api.revanced.app/v2/revanced-patches/releases/latest?dev=true
So, I thought it wasn't implemented yet.
That's why I limited to GitHub API only. I didn't know the cache issue.

If the cache issue will be fixed, I think I should wait for it.

Are changelogs/updates considered as well?

Yes. These lines change the data source of patches update dialog according to the settings.

revanced-manager/lib/ui/views/home/home_viewmodel.dart

Lines 482 to 490 in e88e997

    
           Future<Map<String, dynamic>?> getLatestPatchesRelease() { 
        
             if (_managerAPI.isUsingAlternativeSources() && 
        
                 _managerAPI.isUsingPrereleasePatches()) { 
        
               return _githubAPI 
        
                   .getLatestReleaseWithPreReleases(_managerAPI.getPatchesRepo()); 
        
             } else { 
        
               return _githubAPI.getLatestRelease(_managerAPI.getPatchesRepo()); 
        
             } 
        
           }

brian6932 · 2024-04-16T21:09:24Z

One thing I noticed after building this branch (rebased) was that checking for Revanced Manager updates gets stuck on Loading..., patches work fine though. Is that just a quirk of debug builds, or an issue with the PR?

nivranaitsirhc · 2024-04-20T10:59:03Z

One thing I noticed after building this branch (rebased) was that checking for Revanced Manager updates gets stuck on Loading..., patches work fine though. Is that just a quirk of debug builds, or an issue with the PR?

Can you share the apk here please

brian6932 · 2024-04-20T11:07:37Z

@nivranaitsirhc sure [redacted]

nivranaitsirhc · 2024-04-20T11:43:39Z

@nivranaitsirhc sure [redacted]

It works like a charm! Thanks!

# Conflicts: # lib/services/github_api.dart # lib/services/manager_api.dart # lib/ui/views/home/home_viewmodel.dart

If there are multiple dev releases on the same day, they will be sorted by alphabetically. Therefore, releases[0] is not guaranteed to be the latest. vX.X.X-dev.10 will be older than vX.X.X-dev.9 so we have to iterate several releases and find the latest

kitadai31 · 2024-05-14T09:50:54Z

Waiting for the parameter issue in ReVanced API to be fixed

I have some questions

I added the ReVanced API v2 related logic in revanced_api.dart, but should I split the file into two files like revanced_api_v2.dart ?
I added a word "(dev)" in settings description because ReVanced calls pre-release versions “dev” officially.
Is this no problem? (40b1589)

If the stable version is newer than the most recent pre-release, then the stable version will be used, so make it clear.

Ushie

@oSumAtrIX Does v3 suffer from the same issues regarding the ?dev parameter, supporting the API is a prerequisite for this PR

Ushie · 2024-08-07T23:44:40Z

lib/services/github_api.dart

+  Future<Map<String, dynamic>?> getLatestReleaseWithPreReleases(
+    String repoName,
+  ) async {
+    try {
+      final response = await _dio.get('/repos/$repoName/releases?per_page=10');
+      final List<dynamic> releases = response.data;
+
+      /*
+      * Loop through all releases (including pre-releases) and return the latest
+      */
+      Map<String, dynamic>? latestRelease;
+      DateTime latestReleaseDate = DateTime.fromMillisecondsSinceEpoch(0);
+      for (final release in releases) {
+        final DateTime releaseDate = DateTime.parse(release['published_at']);
+        if (releaseDate.isAfter(latestReleaseDate)) {
+          latestReleaseDate = releaseDate;
+          latestRelease = release;
+        }
+      }
+      return latestRelease;
+    } on Exception catch (e) {
+      if (kDebugMode) {
+        print(e);
+      }
+      return null;
+    }
+  }
+


Maybe instead of making a new function, add a parameter to the existing one instead

oSumAtrIX · 2024-08-07T23:47:42Z

A ?dev query parameter does intendedly not exist and is not planned to be added. The TLDR is that the dev branch is not a controlled release channel like a "beta" channel would be. If we were to want to add a beta channel, we would need do introduce significant changes as well as maintenance overhead as the beta channel would be a new production channel next to the main channel.

Ushie · 2024-08-07T23:50:44Z

The dev branch has nothing to do with this, the flag can be renamed to ?prereleases instead of ?dev because it simply enables returning prereleases

oSumAtrIX · 2024-08-07T23:54:34Z

The name does not change that pre releases are not a controlled production release channel. Any further discussion should happen in the API repo and not in this PR

kitadai31 · 2024-08-08T05:02:28Z

Yeah, I've heard that ReVanced API v2 was deprecated.
And v3 doesn't have toggles for pre-releases.

So, I think it's enough to revert this PR to the beginning. (Pre-release requires alternative sources to be enabled, #1785 (comment))

feat: Pre-release patches toggle

e88e997

Ushie force-pushed the dev branch from c86f0bc to a971cbd Compare March 30, 2024 00:07

TheAabedKhan linked an issue Apr 14, 2024 that may be closed by this pull request

feat: add feature/setting to pick pre-release patches instead #1867

Open

3 tasks

validcube linked an issue Apr 18, 2024 that may be closed by this pull request

feat: allow dev channel patches #821

Closed

4 tasks

kitadai31 mentioned this pull request Apr 21, 2024

bug: Query parameters are unstable due to CloudFlare cache ReVanced/revanced-api#177

Closed

kitadai31 added 5 commits May 11, 2024 13:37

Merge remote-tracking branch 'origin/dev' into feat/prerelease-patches2

e8c63e6

# Conflicts: # lib/services/github_api.dart # lib/services/manager_api.dart # lib/ui/views/home/home_viewmodel.dart

fix fetching pre-release logic

47c411b

If there are multiple dev releases on the same day, they will be sorted by alphabetically. Therefore, releases[0] is not guaranteed to be the latest. vX.X.X-dev.10 will be older than vX.X.X-dev.9 so we have to iterate several releases and find the latest

support ReVanced API

1b25454

improve wording

cb0106d

improve string

40b1589

kitadai31 marked this pull request as draft May 14, 2024 09:30

improve string: add "if available" to the description

d740d31

If the stable version is newer than the most recent pre-release, then the stable version will be used, so make it clear.

Ushie requested changes Aug 7, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Pre-release patches toggle #1785

feat: Pre-release patches toggle #1785

kitadai31 commented Mar 25, 2024 •

edited

Loading

Ushie commented Mar 25, 2024

oSumAtrIX commented Mar 25, 2024

kitadai31 commented Mar 25, 2024 •

edited

Loading

brian6932 commented Apr 16, 2024 •

edited

Loading

nivranaitsirhc commented Apr 20, 2024

brian6932 commented Apr 20, 2024 •

edited by oSumAtrIX

Loading

nivranaitsirhc commented Apr 20, 2024 •

edited by oSumAtrIX

Loading

kitadai31 commented May 14, 2024 •

edited

Loading

Ushie left a comment

Ushie Aug 7, 2024

oSumAtrIX commented Aug 7, 2024 •

edited

Loading

Ushie commented Aug 7, 2024

oSumAtrIX commented Aug 7, 2024

kitadai31 commented Aug 8, 2024

feat: Pre-release patches toggle #1785

Are you sure you want to change the base?

feat: Pre-release patches toggle #1785

Conversation

kitadai31 commented Mar 25, 2024 • edited Loading

Ushie commented Mar 25, 2024

oSumAtrIX commented Mar 25, 2024

kitadai31 commented Mar 25, 2024 • edited Loading

brian6932 commented Apr 16, 2024 • edited Loading

nivranaitsirhc commented Apr 20, 2024

brian6932 commented Apr 20, 2024 • edited by oSumAtrIX Loading

nivranaitsirhc commented Apr 20, 2024 • edited by oSumAtrIX Loading

kitadai31 commented May 14, 2024 • edited Loading

Ushie left a comment

Choose a reason for hiding this comment

Ushie Aug 7, 2024

Choose a reason for hiding this comment

oSumAtrIX commented Aug 7, 2024 • edited Loading

Ushie commented Aug 7, 2024

oSumAtrIX commented Aug 7, 2024

kitadai31 commented Aug 8, 2024

kitadai31 commented Mar 25, 2024 •

edited

Loading

kitadai31 commented Mar 25, 2024 •

edited

Loading

brian6932 commented Apr 16, 2024 •

edited

Loading

brian6932 commented Apr 20, 2024 •

edited by oSumAtrIX

Loading

nivranaitsirhc commented Apr 20, 2024 •

edited by oSumAtrIX

Loading

kitadai31 commented May 14, 2024 •

edited

Loading

oSumAtrIX commented Aug 7, 2024 •

edited

Loading