Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

feat: add query results expired ttl #61

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

gaecoli
Copy link
Member

@gaecoli gaecoli commented Jun 20, 2023

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@gaecoli
Copy link
Member Author

gaecoli commented Jun 20, 2023

#31 #47

@gaecoli
Copy link
Member Author

gaecoli commented Jun 20, 2023

@justinclift I add #31 feat. Maybe can solve #47 problem.

The user can choose to enable the configuration, and the status is not enabled by default. If the user enables the query result expiration function, each query will check whether the TTL has been exceeded and re-query. Works well for data from a large number of changing sources used in the enterprise.

Copy link
Member

@justinclift justinclift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself looks fine. 😄

@justinclift justinclift merged commit d2ac245 into master Jun 20, 2023
8 checks passed
@justinclift justinclift deleted the add-query-result-expired-ttl branch June 20, 2023 04:56
@justinclift
Copy link
Member

@gaecoli Good stuff. As this introduces two new environment variables, I've just added them to a table on the front page of our wiki:

https://github.com/RedashCommunity/redash/wiki

Ideally we'll put all of the environment variables that Redash uses somewhere useful (probably on a dedicated wiki page). We can likely copy the old Redash knowledge base page as a starting point.

@gaecoli
Copy link
Member Author

gaecoli commented Jun 20, 2023

@gaecoli Good stuff. As this introduces two new environment variables, I've just added them to a table on the front page of our wiki:

https://github.com/RedashCommunity/redash/wiki

Ideally we'll put all of the environment variables that Redash uses somewhere useful (probably on a dedicated wiki page). We can likely copy the old Redash knowledge base page as a starting point.

OK.

@justinclift
Copy link
Member

justinclift commented Jun 20, 2023

I've added a few more environment variables to that page, and will probably do the rest tonight.

There's a lot that have been added since the existing Redash page about them was last updated.

@gaecoli
Copy link
Member Author

gaecoli commented Jun 20, 2023

I've added a few more environment variables to that page, and will probably do the rest tonight.

There's a lot that have been added since the existing Redash page about them was last updated.

I will help you complete it. Don't worry!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants