Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @lavamoat/allow-scripts setup #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

naugtur
Copy link

@naugtur naugtur commented Apr 13, 2024

TODO:

  • discuss whether web-ext>bunyan>dtrace-provider is needed
  • check if esbuild can work without scripts... wait - esbuild doesn't seem to be used. Does tsx use it now?

Copy link

socket-security bot commented Apr 13, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@lavamoat/[email protected] None 0 19.8 kB boneskull
npm/@lavamoat/[email protected] environment 0 45.8 kB boneskull
npm/@lavamoat/[email protected] None 0 3.25 kB naugtur
npm/@npmcli/[email protected] environment, network 0 17.7 kB npm-cli-ops
npm/@npmcli/[email protected] filesystem 0 26.5 kB lukekarrys
npm/@npmcli/[email protected] filesystem 0 21.8 kB npm-cli-ops
npm/@npmcli/[email protected] filesystem 0 1.87 kB lukekarrys
npm/@npmcli/[email protected] filesystem 0 37.4 kB npm-cli-ops
npm/@npmcli/[email protected] environment, shell 0 12 kB npm-cli-ops
npm/@npmcli/[email protected] environment 0 18.4 kB npm-cli-ops
npm/[email protected] None 0 4.83 kB lukekarrys
npm/[email protected] network 0 31.2 kB tootallnate
npm/[email protected] filesystem 0 20.6 kB npm-cli-ops
npm/[email protected] None 0 3.7 kB juliangruber
npm/[email protected] filesystem 0 63.6 kB npm-cli-ops
npm/[email protected] filesystem 0 5.75 kB isaacs
npm/[email protected] filesystem 0 12.1 kB npm-cli-ops
npm/[email protected] None 0 9.23 kB isaacs
npm/[email protected] None 0 12.7 kB iarna
npm/[email protected] None 0 7.12 kB andris
npm/[email protected] None 0 10.2 kB sindresorhus
npm/[email protected] None 0 12.3 kB achingbrain
npm/[email protected] None 0 37.3 kB sssayegh
npm/[email protected] filesystem 0 14.4 kB npm-cli-ops
npm/[email protected] environment 0 3.44 kB iarna
npm/[email protected] None 0 26.7 kB npm-cli-ops
npm/[email protected] network 0 23.3 kB tootallnate
npm/[email protected] network 0 35.3 kB tootallnate
npm/[email protected] None 0 349 kB ashtuchkin
npm/[email protected] filesystem 0 4.29 kB isaacs
npm/[email protected] None 0 177 kB beaugunderson
npm/[email protected] None 0 13.6 kB indutny
npm/[email protected] None 0 2.94 kB watson
npm/[email protected] None 0 46.9 kB andyperlitch
npm/[email protected] None 0 9.87 kB npm-cli-ops
npm/[email protected] network 0 52.5 kB npm-cli-ops
npm/[email protected] None 0 4.96 kB isaacs
npm/[email protected] environment, network 0 46.8 kB npm-cli-ops
npm/[email protected] None 0 3.77 kB isaacs
npm/[email protected] None +1 55.1 kB isaacs
npm/[email protected] None 0 124 kB isaacs
npm/[email protected] None 0 17.3 kB isaacs
npm/[email protected] None 0 27.4 kB dougwilson
npm/[email protected] environment, shell +1 2.19 MB lukekarrys
npm/[email protected] None 0 26.1 kB npm-cli-ops
npm/[email protected] None 0 28.3 kB npm-cli-ops
npm/[email protected] None 0 6.21 kB npm-cli-ops
npm/[email protected] None 0 3.58 kB npm-cli-ops
npm/[email protected] None 0 19.1 kB npm-cli-ops
npm/[email protected] None 0 16.4 kB npm-cli-ops
npm/[email protected] None 0 8.69 kB sindresorhus
npm/[email protected] None 0 5.21 kB lukekarrys
npm/[email protected] None 0 3.04 kB iarna
npm/[email protected] None 0 15.6 kB achingbrain
npm/[email protected] filesystem 0 5.16 kB lukekarrys
npm/[email protected] None 0 32.2 kB tim-kos
npm/[email protected] None 0 4.22 kB bcoe
npm/[email protected] None 0 138 kB joshglazebrook
npm/[email protected] network 0 25.1 kB tootallnate
npm/[email protected] network 0 156 kB joshglazebrook
npm/[email protected] None 0 17.4 kB matteo.collina
npm/[email protected] None 0 39.9 kB alexei
npm/[email protected] None 0 38.7 kB npm-cli-ops
npm/[email protected] environment, filesystem +2 250 kB isaacs
npm/[email protected] None 0 3.41 kB lukekarrys
npm/[email protected] None 0 2.58 kB lukekarrys
npm/[email protected] None 0 7.88 kB lukekarrys
npm/[email protected] environment 0 7.5 kB npm-cli-ops
npm/[email protected] filesystem 0 12.2 kB npm-cli-ops

🚮 Removed packages: npm/@amplitude/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@discoveryjs/[email protected], npm/@jridgewell/[email protected], npm/@npmcli/[email protected], npm/@npmcli/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webpack-cli/[email protected], npm/@webpack-cli/[email protected], npm/@webpack-cli/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented Apr 13, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@lavamoat/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@naugtur
Copy link
Author

naugtur commented Apr 13, 2024

@SocketSecurity ignore npm/@lavamoat/[email protected]
it's the whole point of the package

@rkalis
Copy link
Member

rkalis commented Jun 7, 2024

Hey, thanks for the PR and apologies for the lack of reply. I looked into the points in your TODOs. As far as I can tell, we should be able to set web-ext>bunyan>dtrace-provider to false.

Re: esbuild, tsx does need esbuild to function, and from what I can see, I don't think we can disable scripts for esbuild. However, we currently only have tsx installed as a devDependency to run some of the TS scripts in the scripts/ directory. e.g. yarn tsx scripts/get-signature.tsx .... So that means we could also remove tsx from the devDependencies and install it globally instead, if you think that'd be a safer option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants