CI: Tweaks for the tag creating jobs

[romainpi]

Hello there, this is a follow up to #589

Code changes

Some tweaks for the Github actions:

• Makes sure the create-tags-for-past-releases job runs before create-git-tag.
  Since jobs run in parallel create-git-tag could run before create-tags-for-past-releases and would create a tag for 0.19.0 on the latest commit on master. The job create-git-tag will now always run after create-tags-for-past-releases.
• Have the create-git-tag fetch all Git history to actually be able to detect past tags.
  Now the checkout fetches the whole git history allowing it to see if the current version is indeed tagged or not.

Fine grain token

I have tested with the fine-grain tokens and the following setting works. @est31 may I ask you to do the following please

1. Regenerate a fine-grain personal access token here with the following settings:

• Token name: Something like "Token for Rodio CI release tagging"
• Expiration: Any value you would like, you understand that it will have to be periodically regenerated. The secrets scanning page for the project should theoretically warn you when it is expired.
• Repository access: You only need to select the RustAudio/Rodio repo.
• Permissions:
  • Contents: Read and Write (in order to create releases/tags)
  • Metadata: Read (mandatory)
  • Workflows (at the very bottom of the list): Read and Write (because apparently tagging commits which are anywhere near something that modified a workflow file counts as modifying that workflow?)

2. Edit the WORKFLOW_TOKEN repo secret here (or create the WORKFLOW_TOKEN secret if it doesn't exist) and paste the newly created fine-grained PAT.
3. Finally merging this very PR.

Here's a screenshot of my fine-grained PAT that succesfully ran on the master of my fork:

Thanks!

[dvdsk]

I have applied the old tags locally and can push them. If your okay with that you can remove the create old tags part. That should simplify the workflow.

[est31]

@romainpi I have updated the WORKFLOW_TOKEN as per your listed steps. Thanks for writing this all up so nicely.

[romainpi]

I have applied the old tags locally and can push them. If your okay with that you can remove the create old tags part. That should simplify the workflow.

Yes well the create-tags-for-past-releases job was meant to be ephemeral. The result will be the same if you merge this PR now or manually push the tags (I can't be sure the tags are correct on your machine but I assume they are - I know the tags coming from this PR are the correct ones IMO). I'm ready to push a PR removing the create-tags-for-past-releases workflow as soon as the tags are activated on this repo!

[romainpi]

I have applied the old tags locally and can push them. If your okay with that you can remove the create old tags part. That should simplify the workflow.

Yes well the create-tags-for-past-releases job was meant to be ephemeral. The result will be the same if you merge this PR now or manually push the tags (I can't be sure the tags are correct on your machine but I assume they are - I know the tags coming from this PR are the correct ones IMO). I'm ready to push a PR removing the create-tags-for-past-releases workflow as soon as the tags are activated on this repo!

Actually @dvdsk it's better to push this PR now because it contains an important fix to the create-git-tag job.

[dvdsk]

so now we need another PR to remove the epheremal job right?

[romainpi]

so now we need another PR to remove the epheremal job right?

Yes indeed! See #596.