Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused variable warning introduced by #446 #453

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bobpaw
Copy link
Collaborator

@bobpaw bobpaw commented Sep 13, 2024

Fix unused variable warning introduced by #446

This fixes an unused warning when CMake is given -DENABLE_CAPSTONE by casting to void.

However, I wonder if we can remove the #ifndef altogether? Currently we expect Capstone meshes to never be periodic. But if they are periodic, I would expect we might want to do the recalculation.

@bobpaw bobpaw requested a review from cwsmith September 13, 2024 15:01
Copy link
Contributor

@cwsmith cwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'm not familiar enough with the context of the ifdef to provide a helpful response regarding its existence/usefulness.

@bobpaw
Copy link
Collaborator Author

bobpaw commented Sep 13, 2024

@onkarsahni Do you have any insights in terms of Capstone and periodic meshes? Is that something they might support in the future? If we remove the #ifndef HAVE_CAPSTONE the expensive parametric call still won't be made unless it's a 2d periodic mesh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants