-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example encoder config option #107
Conversation
@@ -34,7 +29,7 @@ class ExampleContextImpl : ExampleContext { | |||
*/ | |||
fun add(routes: Collection<RouteMeta>) { | |||
collectExampleDescriptors(routes).forEach { exampleDescriptor -> | |||
rootExamples[exampleDescriptor] = generateExample(exampleDescriptor) | |||
rootExamples[exampleDescriptor] = exampleDescriptor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i am missing why we need to generate the example in the getter and not here. Couldn't collectExampleDescriptors
return the descriptor together with a type so that we can generate the final swagger Example object here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did the thing, maybe you can merge and release soon 🙂
Hi @SMILEY4, is there anything I can help with to get this PR merged? |
thank you and sorry for the delay. PR looks good in my opinion - there is an open question of understanding from my side but i think we can still merge it. I'll try to close it soon and release a new version for it. |
738581a
to
aec52a8
Compare
Closes #105