Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example configuration for LazyVim #2566

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

johnpitchko
Copy link
Contributor

Motivation

Fix configuration for Lazyvim by wrapping the servers table within the opts table.

When I tested this on my Lazyvim installation, the configuration did not work as documented. However, once I updated the config to be wrapped in the opts table, the LSP was loaded successfully.

:LspInfo using included config:
Screenshot 2024-09-18 at 21 40 47

:LspInfo using modified config:
Screenshot 2024-09-18 at 21 41 44

Implementation

Automated Tests

Manual Tests

Fix configuration for Lazyvim by wrapping the `servers` table within the `opts` table.
@johnpitchko
Copy link
Contributor Author

I have signed the CLA!

@andyw8
Copy link
Contributor

andyw8 commented Sep 19, 2024

I'm not a LazyVim user but I see the same change suggested here so this seems valid.

cc @willian @adipasquale

@andyw8 andyw8 changed the title Update editors.markdown Update example configuration for LazyVim Sep 19, 2024
@andyw8 andyw8 added documentation Improvements or additions to documentation server This pull request should be included in the server gem's release notes labels Sep 19, 2024
@andyw8 andyw8 merged commit 2243eca into Shopify:main Sep 19, 2024
20 checks passed
Copy link

@adipasquale adipasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation server This pull request should be included in the server gem's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants