forked from vitessio/vitess
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BACK-PORT] Properly support ignore_nulls in CreateLookupVindex (#13913) #122
Merged
austenLacy
merged 2 commits into
v15.0.3-shopify-7
from
austenlacy/vitess-project-485/backport-ignore_nulls-support-in-createlookupvindex
Sep 19, 2023
Merged
[BACK-PORT] Properly support ignore_nulls in CreateLookupVindex (#13913) #122
austenLacy
merged 2 commits into
v15.0.3-shopify-7
from
austenlacy/vitess-project-485/backport-ignore_nulls-support-in-createlookupvindex
Sep 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Lord <[email protected]>
austenLacy
requested review from
Hammadk,
vahe,
brendar,
adisonlampert and
shanth96
September 18, 2023 14:28
Signed-off-by: Austen Lacy <[email protected]>
austenLacy
force-pushed
the
austenlacy/vitess-project-485/backport-ignore_nulls-support-in-createlookupvindex
branch
from
September 18, 2023 15:20
4908d0a
to
1b2ba1f
Compare
brendar
approved these changes
Sep 18, 2023
Hammadk
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
austenLacy
deleted the
austenlacy/vitess-project-485/backport-ignore_nulls-support-in-createlookupvindex
branch
September 19, 2023 17:11
shanth96
pushed a commit
that referenced
this pull request
Mar 21, 2024
…ssio#13913) (#122) * Properly support ignore_nulls in CreateLookupVindex (vitessio#13913) Signed-off-by: Matt Lord <[email protected]> * remove new vreplication tests that dont work with v15 Signed-off-by: Austen Lacy <[email protected]> --------- Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Austen Lacy <[email protected]> Co-authored-by: Matt Lord <[email protected]> Co-authored-by: Austen Lacy <[email protected]> (cherry picked from commit ebde310)
shanth96
pushed a commit
that referenced
this pull request
May 10, 2024
…ssio#13913) (#122) * Properly support ignore_nulls in CreateLookupVindex (vitessio#13913) Signed-off-by: Matt Lord <[email protected]> * remove new vreplication tests that dont work with v15 Signed-off-by: Austen Lacy <[email protected]> --------- Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Austen Lacy <[email protected]> Co-authored-by: Matt Lord <[email protected]> Co-authored-by: Austen Lacy <[email protected]> (cherry picked from commit ebde310) (cherry picked from commit 07c6f4a)
shivnagarajan
pushed a commit
that referenced
this pull request
May 19, 2024
…ssio#13913) (#122) * Properly support ignore_nulls in CreateLookupVindex (vitessio#13913) Signed-off-by: Matt Lord <[email protected]> * remove new vreplication tests that dont work with v15 Signed-off-by: Austen Lacy <[email protected]> --------- Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Austen Lacy <[email protected]> Co-authored-by: Matt Lord <[email protected]> Co-authored-by: Austen Lacy <[email protected]> (cherry picked from commit ebde310) (cherry picked from commit 07c6f4a) (cherry picked from commit 428d1bd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back ports vitessio#13913 from upstream to fix the reported bug for
CreateLookupVindex
workflows not respecting theignore_nulls
field.