Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename amarcais53 to HamtaBot #3865

Merged
merged 1 commit into from
Jun 24, 2023
Merged

Conversation

SchnTgaiSpock
Copy link
Contributor

@SchnTgaiSpock SchnTgaiSpock commented Jun 24, 2023

Description

Fixes this error:

[23.06 19:06:06] [Server] [ERROR] [dough: skins] Exception while requesting skin: https://api.mojang.com/users/profiles/minecraft/amarcais53
[23.06 19:06:06] [Server] [WARN] [Slimefun] Attempted to refresh skin cache, got this response: ExecutionException: java.io.FileNotFoundException: https://api.mojang.com/users/profiles/minecraft/amarcais53

https://discord.com/channels/565557184348422174/565569196218384385/1121875045308969071

Proposed changes

Renames amarcais53 to HamtaBot in the translators file

Related Issues (If applicable)

None

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@SchnTgaiSpock
Copy link
Contributor Author

prs from github.dev don't let you use the template 🤦‍♂️

@Sfiguz7 Sfiguz7 added the ✨ Fix This Pull Request fixes an issue. label Jun 24, 2023
@Sfiguz7 Sfiguz7 merged commit 0fa8c9d into Slimefun:master Jun 24, 2023
8 of 9 checks passed
@SchnTgaiSpock SchnTgaiSpock deleted the fix/name-1 branch June 29, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants