Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unirest and replace with Java's native HttpClient #4068

Merged
merged 3 commits into from
Feb 25, 2024

Conversation

WalshyDev
Copy link
Member

@WalshyDev WalshyDev commented Dec 21, 2023

Description

When we first implemented Unirest, the goal was always to remove it once we moved to Java 11 minimum. It's been a while since this happened so let's do this.

This reduces the jar size from 4.7 MB (4782834 bytes) to 2.4 MB (2480486 bytes) so we remove ~2.3 MB.

Proposed changes

Removes Unirest with Java's native HttpClient (introduced in Java 11)

Related Issues (if applicable)

N/A

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@WalshyDev WalshyDev requested review from a team as code owners December 21, 2023 06:53
@github-actions github-actions bot added the 🧹 Chores Refactoring / Cleanup. label Dec 21, 2023
Copy link
Contributor

Your Pull Request was automatically labelled as: "🧹 Chores"
Thank you for contributing to this project! ❤️

Copy link
Contributor

github-actions bot commented Dec 21, 2023

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 296ce2b7

https://preview-builds.walshy.dev/download/Slimefun/4068/296ce2b7

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Copy link
Contributor

@J3fftw1 J3fftw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please create unit tests

@WalshyDev
Copy link
Member Author

This code cannot be unit tested, it's all private or ran as part of a task. Making it public doesn't make sense here

J3fftw1
J3fftw1 previously approved these changes Dec 27, 2023
Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

7 New issues
0 Security Hotspots
1.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@WalshyDev WalshyDev merged commit b841828 into master Feb 25, 2024
17 checks passed
@WalshyDev WalshyDev deleted the chore/remove-unirest branch February 25, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Chores Refactoring / Cleanup.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants