-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace contributor section in guide with a link #4106
base: master
Are you sure you want to change the base?
Conversation
Your Pull Request was automatically labelled as: "🧹 Chores" |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4106/115e71f0
|
- '&7Over &e%contributors% &7people have worked on' | ||
- '&7Many people have worked on' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Iirc this won't update for servers automatically so instead it'll have a not filled placeholder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for english it will automaticall update.
for other languages it need to be manually changed through crowdin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't that only for new keys? It won't override it afaik
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise the point of configs would be kinda moot
Description
This PR replaces the contributor section in the guide with a link.
The contributor section is causing a bunch of warning because contributors change their name. It might not link up with their MC name anymore. This will cause a bunch of warnings. We either replace it by a robust system or change it like this.
The section is barely looked at since there is no benefit to it.
Making a more robust system would just be a waste of time imo.
Proposed changes
Delete contributor section and replace it with a url to https://github.com/Slimefun/Slimefun4/graphs/contributors
Related Issues (if applicable)
There is no open issue.
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values