Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace contributor section in guide with a link #4106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

J3fftw1
Copy link
Contributor

@J3fftw1 J3fftw1 commented Jan 19, 2024

Description

This PR replaces the contributor section in the guide with a link.
The contributor section is causing a bunch of warning because contributors change their name. It might not link up with their MC name anymore. This will cause a bunch of warnings. We either replace it by a robust system or change it like this.
The section is barely looked at since there is no benefit to it.
Making a more robust system would just be a waste of time imo.

Proposed changes

Delete contributor section and replace it with a url to https://github.com/Slimefun/Slimefun4/graphs/contributors

Related Issues (if applicable)

There is no open issue.

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@J3fftw1 J3fftw1 requested a review from a team as a code owner January 19, 2024 20:29
@github-actions github-actions bot added the 🧹 Chores Refactoring / Cleanup. label Jan 19, 2024
Copy link
Contributor

Your Pull Request was automatically labelled as: "🧹 Chores"
Thank you for contributing to this project! ❤️

Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 115e71f0

https://preview-builds.walshy.dev/download/Slimefun/4106/115e71f0

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

- '&7Over &e%contributors% &7people have worked on'
- '&7Many people have worked on'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iirc this won't update for servers automatically so instead it'll have a not filled placeholder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for english it will automaticall update.
for other languages it need to be manually changed through crowdin.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that only for new keys? It won't override it afaik

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise the point of configs would be kinda moot

@TheBusyBot TheBusyBot added the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Chores Refactoring / Cleanup. ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants