Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeprecate the CS-Core stuff for now #4187

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

Seggan
Copy link
Contributor

@Seggan Seggan commented May 7, 2024

Description

Undepreated the old stuff in me.mrCookieSlime. This was done because we have no replacement yet, and the IDE warnings are getting annoying in addons. Deprecate these after having a replacement.

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I added sufficient Unit Tests to cover my code.

@Seggan Seggan requested a review from a team as a code owner May 7, 2024 19:12
@github-actions github-actions bot added the 🔧 API This Pull Request introduces API changes. label May 7, 2024
@Seggan Seggan changed the title Undeprecate the CsCore stuff for now Undeprecate the CS-Core stuff for now May 7, 2024
Copy link
Contributor

github-actions bot commented May 7, 2024

Your Pull Request was automatically labelled as: "🔧 API"
Thank you for contributing to this project! ❤️

Copy link
Contributor

github-actions bot commented May 7, 2024

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 5c1e617f

https://preview-builds.walshy.dev/download/Slimefun/4187/5c1e617f

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Copy link
Contributor

@J3fftw1 J3fftw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i wanted this for a while now as well

Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@Sefiraat
Copy link
Member

Sefiraat commented May 8, 2024

I’ve not had a chance to actually review the code changes (which I’m sure are sound) but I am all-for this change. 100% support this ha!

@TheBusyBiscuit TheBusyBiscuit merged commit 5b8d872 into Slimefun:master Aug 8, 2024
15 checks passed
@Seggan Seggan deleted the api/undeprecate branch August 8, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 API This Pull Request introduces API changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants