Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: localization for options menu #4189

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

ybw0014
Copy link
Contributor

@ybw0014 ybw0014 commented May 12, 2024

Description

These buttons in settings can be translated.

I modified the messages.yml to add an a at the end of fireworks option. The messages are read properly.
image

Proposed changes

Add localization for guide mode and fireworks option in the settings menu.

Related Issues (if applicable)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@ybw0014 ybw0014 requested a review from a team as a code owner May 12, 2024 16:26
@github-actions github-actions bot added the 🧹 Chores Refactoring / Cleanup. label May 12, 2024
Copy link
Contributor

Your Pull Request was automatically labelled as: "🧹 Chores"
Thank you for contributing to this project! ❤️

Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 98f92c3d

https://preview-builds.walshy.dev/download/Slimefun/4189/98f92c3d

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Copy link
Member

@TheBusyBiscuit TheBusyBiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WalshyDev WalshyDev merged commit b560db1 into Slimefun:master Sep 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Chores Refactoring / Cleanup.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants