Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code duplication #4230

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

Intybyte
Copy link
Contributor

@Intybyte Intybyte commented Sep 4, 2024

Description

The same output handler is used in many parts of the code and it would be better to have a defaul handler

Proposed changes

Add a default handler to the ChestMenuUtils, similar to the already existing ChestMenuUtils#getEmptyClickHandler method

Related Issues (if applicable)

https://sonarcloud.io/project/issues?open=AXTBL6ehIVI46B1gLWaW&id=Slimefun_Slimefun4

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@Intybyte Intybyte requested a review from a team as a code owner September 4, 2024 11:00
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 86124cf

https://preview-builds.walshy.dev/download/Slimefun/4230/86124cf4

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@JustAHuman-xD JustAHuman-xD added the 🧹 Chores Refactoring / Cleanup. label Sep 4, 2024
Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Sfiguz7 Sfiguz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep LGTM too

@Sfiguz7 Sfiguz7 merged commit 9a64617 into Slimefun:master Sep 6, 2024
15 checks passed
@Intybyte Intybyte deleted the chores/default_output_handler branch September 6, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Chores Refactoring / Cleanup.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants