Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log non-200 on metrics download #4239

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

WalshyDev
Copy link
Member

Description

We didn't have a log line for this previously so it would say "failed to download" but not provide any further info. This provides that info

Proposed changes

Log that we got a non-200 status code and log the code.

Related Issues (if applicable)

N/A

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@WalshyDev WalshyDev requested a review from a team as a code owner September 9, 2024 03:06
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

Copy link

sonarcloud bot commented Sep 9, 2024

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: f2afef4

https://preview-builds.walshy.dev/download/Slimefun/4239/f2afef4f

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@WalshyDev WalshyDev merged commit 0a7fea8 into master Sep 22, 2024
16 checks passed
@WalshyDev WalshyDev deleted the walshy/log-non-200-metrics-download branch September 22, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants