Skip to content

Commit

Permalink
Support 1.20.6 (#271)
Browse files Browse the repository at this point in the history
* Support 1.20.6 and add paper adapters

* remove space

* reduce to one call

* fix build due to funnyguilds invalid dependency

* use registry instead of enum

* fix: use old getter of property for older versions

* Put paper adapter behind 1.19.4 gate

The adapter is using adventure which was not bundled into Paper until 1.19.4
so to support it, we can only use this version or higher.

* Disable paper head adapter

---------

Co-authored-by: ybw0014 <[email protected]>
Co-authored-by: Daniel Walsh <[email protected]>
  • Loading branch information
3 people committed Sep 9, 2024
1 parent baf2d79 commit f8ff251
Show file tree
Hide file tree
Showing 14 changed files with 374 additions and 38 deletions.
11 changes: 7 additions & 4 deletions dough-api/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,6 @@
<id>enginehub-repo</id>
<url>https://maven.enginehub.org/repo/</url>
</repository>
<repository>
<id>IntellectualSites</id>
<url>https://mvn.intellectualsites.com/content/repositories/snapshots/</url>
</repository>
<repository>
<id>funnyguilds-repo</id>
<url>https://repo.panda-lang.org/releases</url>
Expand Down Expand Up @@ -415,6 +411,13 @@
<artifactId>plugin</artifactId>
<version>4.12.0</version>
<scope>provided</scope>
<exclusions>
<!-- Exclude invalid dependency -->
<exclusion>
<groupId>com.github.PikaMug</groupId>
<artifactId>LocaleLib</artifactId>
</exclusion>
</exclusions>
</dependency>

<!-- HuskTowns -->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
import javax.annotation.Nullable;

import org.bukkit.Material;
import org.bukkit.NamespacedKey;
import org.bukkit.Registry;
import org.bukkit.enchantments.Enchantment;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.Damageable;
Expand Down Expand Up @@ -174,8 +176,8 @@ public static void damageItem(@Nonnull ItemStack item, int damage, boolean ignor
if (item.getType() != Material.AIR && item.getAmount() > 0) {
int remove = damage;

if (!ignoreEnchantments && item.getEnchantments().containsKey(Enchantment.DURABILITY)) {
int level = item.getEnchantmentLevel(Enchantment.DURABILITY);
if (!ignoreEnchantments && item.getEnchantments().containsKey(Registry.ENCHANTMENT.get(NamespacedKey.minecraft("unbreaking")))) {
int level = item.getEnchantmentLevel(Registry.ENCHANTMENT.get(NamespacedKey.minecraft("unbreaking")));

for (int i = 0; i < damage; i++) {
if (Math.random() * 100 <= (60 + Math.floorDiv(40, (level + 1)))) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import javax.annotation.Nullable;
import javax.annotation.ParametersAreNonnullByDefault;

import io.papermc.lib.PaperLib;
import org.bukkit.inventory.ItemStack;

import io.github.bakedlibs.dough.common.DoughLogger;
Expand All @@ -20,11 +21,19 @@ public interface ItemNameAdapter {

public static @Nullable ItemNameAdapter get() {
try {
MinecraftVersion version = MinecraftVersion.get();

if (MinecraftVersion.isMocked()) {
// Special case for MockBukkit
return new ItemNameAdapterMockBukkit();
}

MinecraftVersion version = MinecraftVersion.get();

if (version.isAtLeast(1, 20, 4) && PaperLib.isPaper()) {
return new ItemNameAdapterPaper();
}

if (version.isAtLeast(1, 20, 5)) {
return new ItemNameAdapter20v5();
} else if (version.isAtLeast(1, 20)) {
return new ItemNameAdapter20();
} else if (version.isAtLeast(1, 19)) {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
package io.github.bakedlibs.dough.items.nms;

import io.github.bakedlibs.dough.reflection.ReflectionUtils;
import io.github.bakedlibs.dough.versions.UnknownServerVersionException;
import org.bukkit.inventory.ItemStack;

import javax.annotation.ParametersAreNonnullByDefault;
import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;

class ItemNameAdapter20v5 implements ItemNameAdapter {

private final Method getCopy;
private final Method getName;
private final Method toString;

ItemNameAdapter20v5() throws NoSuchMethodException, SecurityException, ClassNotFoundException, UnknownServerVersionException {
super();

getCopy = ReflectionUtils.getOBCClass("inventory.CraftItemStack").getMethod("asNMSCopy", ItemStack.class);
getName = ReflectionUtils.getMethodOrAlternative(ReflectionUtils.getNetMinecraftClass("world.item.ItemStack"), "getDisplayName", "G");
toString = ReflectionUtils.getMethod(ReflectionUtils.getNetMinecraftClass("network.chat.IChatBaseComponent"), "getString");
}

@Override
@ParametersAreNonnullByDefault
public String getName(ItemStack item) throws IllegalAccessException, InvocationTargetException {
Object instance = getCopy.invoke(null, item);
return (String) toString.invoke(getName.invoke(instance));
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
package io.github.bakedlibs.dough.items.nms;

import net.kyori.adventure.text.serializer.plain.PlainTextComponentSerializer;
import org.bukkit.Bukkit;
import org.bukkit.inventory.ItemStack;

import javax.annotation.ParametersAreNonnullByDefault;
import java.lang.reflect.InvocationTargetException;

public class ItemNameAdapterPaper implements ItemNameAdapter {
@Override
@ParametersAreNonnullByDefault
public String getName(ItemStack item) throws IllegalAccessException, InvocationTargetException {
return PlainTextComponentSerializer.plainText().serialize(Bukkit.getItemFactory().displayName(item));
}
}
Loading

0 comments on commit f8ff251

Please sign in to comment.