Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: switch P256 implementation from FCL_elliptic to OpenZeppelin #133

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

refactor: switch P256 implementation from FCL_elliptic to OpenZeppelin #133

wants to merge 5 commits into from

Conversation

davidinsuomi
Copy link
Collaborator

  1. Using P256 Verification method: Updated the P256 method from recover to verify to comply with the RIP-7212 standard.
  2. Switch p256 to OpenZeppelin Library: using OpenZeppelin’s p256 library, which uses the RIP-7212 precompile for secp256r1 signature verification, with a fallback to Solidity implementation if needed.
  3. Switch RS256 to OpenZeppelin Library: Removed the custom RS256 implementation and replaced it with OpenZeppelin’s library.
  4. On Hold: This PR is currently on hold as the version of OpenZeppelin's library being used has not yet been audited.

The changes are intended to address potential issues in the FCL recover method.

@davidinsuomi davidinsuomi mentioned this pull request Sep 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayden-sudo jayden-sudo Awaiting requested review from jayden-sudo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidinsuomi