Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{I,D}BusSimplePlugin: don't rely on memoryTranslatorPortConfig != null #307

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Feb 24, 2023

  1. {I,D}BusSimplePlugin: don't rely on memoryTranslatorPortConfig != null

    `null` can be a valid `MemoryTranslator` configuration parameter, for
    example in the case of the `PmpPlugin`. Furthermore, the
    `IBusCachedPlugin` and `DBusCachedPlugin` do not generally rely on its
    `memoryTranslatorPortConfig` to be non-null to instantiate its
    translator port, but instead checks whether a `MemoryTranslator`
    service exists in the pipeline. Thus it seems best to change
    `IBusSimplePlugin` and `DBusSimplePlugin` to behave identically to the
    their respective cached versions.  This also prevents accidental CPU
    misconfigurations where an MMU or PMP plugin is instantiated and
    generally usable, but does not actually take effect in the memory
    buses.
    lschuermann committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    c89b7a2 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2023

  1. DBusSimplePlugin: do not set skipCmd on MMU_FAULT

    This is to avoid a combinational loop.
    lschuermann committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    00ebc98 View commit details
    Browse the repository at this point in the history