Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update_dashboard #76: Correct Payload #77

Conversation

jpavlav
Copy link
Contributor

@jpavlav jpavlav commented Mar 28, 2024

Turns out during my testing, I forgot to have a permutation where I updated the permissions of a dashboard. Discovered the payload is malformed because of a lack of post-processing in the jira lib (this is as intended). This PR fixes the issue.

  • Update keys in payload dict for update_dashboard action from edit_permissions/share_permissions to
    editPermissions/sharePermissions to make the jira API happy.

Turns out during my testing, I forgot to have a permutation where I
updated the permissions of a dashboard. Discovered the payload is
malformed because of a lack of post-processing in the `jira` lib (this
is as intended). This PR fixes the issue.

* Update keys in payload dict for `update_dashboard` action from
`edit_permissions/share_permissions` to
`editPermissions/sharePermissions` to make the `jira` API happy.
@jpavlav jpavlav requested review from floatingstatic and a team as code owners March 28, 2024 18:24
@jpavlav jpavlav requested review from Kami and removed request for a team March 28, 2024 18:24
@jpavlav
Copy link
Contributor Author

jpavlav commented Mar 28, 2024

@floatingstatic Looks like there is something busted with the CI. I wonder if there was a change to the reusable workflow upstream at some point. Anyway, it's blocking this PR.

Run echo "::group::Install virtualenv command"
  echo "::group::Install virtualenv command"
  ./scripts/github/install-virtualenv.sh
  echo "::endgroup::"
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    ST2_REPO_PATH: /home/runner/work/stackstorm-jira/stackstorm-jira/st2
    ROOT_DIR: /home/runner/work/stackstorm-jira/stackstorm-jira/pack
    CI_DIR: /home/runner/work/_actions/StackStorm-Exchange/ci/master
    LINT_CONFIGS_PATH: /home/runner/work/stackstorm-jira/stackstorm-jira/lint-configs
    VIRTUALENV_DIR: /home/runner/virtualenv
    REQUIREMENTS_DIR: /home/runner/work/_actions/StackStorm-Exchange/ci/master/.github/actions/py-dependencies
    pythonLocation: /opt/hostedtoolcache/Python/3.9.19/x[64](https://github.com/StackStorm-Exchange/stackstorm-jira/actions/runs/8471982636/job/23213106571?pr=77#step:5:68)
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.9.19/x64/lib
Install virtualenv command
  /home/runner/.local/bin/virtualenv
  ./scripts/github/install-virtualenv.sh: /home/runner/.local/bin/virtualenv: /home/runner/virtualenv/bin/python: bad interpreter: No such file or directory

@jpavlav
Copy link
Contributor Author

jpavlav commented Mar 30, 2024

@floatingstatic @nzlosh I wonder if maybe the issue is with the cache the github action is using? This error is pretty bizarre considering tests passed for the last PR and afaict there hasn't been anything related to this changed upstream in quite some time.

Copy link
Collaborator

@floatingstatic floatingstatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay. Approving the changes. I will see if I can hunt down a solution for the CI issue. I looked briefly at the CI repo as well and see nothing recent that would impact this. It also strikes me as odd that this worked prior to merging the last PR but do not see how this would be connected at first glance.

@floatingstatic
Copy link
Collaborator

@jpavlav i cleared the actions cache and was able to get this to pass. Thanks for the suggestion. Merging.

@floatingstatic floatingstatic merged commit a4de384 into StackStorm-Exchange:master Apr 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants