Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

realm: add FPGA module #1210

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

realm: add FPGA module #1210

wants to merge 1 commit into from

Conversation

dycz0fx
Copy link

@dycz0fx dycz0fx commented Mar 8, 2022

Add a Realm FPGA module and two vadd examples (one Legion example in examples/fpga, one Realm example in examples/realm_fpga).

@fdouglis
Copy link

fdouglis commented Nov 9, 2022

Pulling for this (pun intended)

@nindanaoto
Copy link

Is this PR going to merge? This seems to be what I hoped to get for a year..... (The task graph based scheduler for heterogeneous environment including FPGA)

@fdouglis
Copy link

fdouglis commented Dec 1, 2022

Really a question for @streichler who self-assigned this. I hope so!

@fdouglis
Copy link

@streichler as I work on the report for our project, I note a comment from the report a year ago about how this would be merged into Legion ... it looks like it's still on the back-burner. Any hope here?

@streichler
Copy link
Contributor

One of the key issues (how to test this in CI) looks like it might be more solved than I thought it was. I see there are instructions for running the examples on an AWS node. Are there any other cloud providers that have compatible hardware?

Another issue is the name of the module. I think "fpga" is too generic (e.g. we didn't call the cuda module "gpu"). If this is specific to Xilinx FPGAs (or maybe even a subset of the Xilinx family?), should we have a more specific name? Or is it mostly an OpenCL interface and might work on other device that support OpenCL?

@fdouglis
Copy link

Thanks for the reply. Not sure about the hardware question. For naming, it is probably pretty xilinx-specific. Perhaps @dycz0fx has some thoughts on that.

@fdouglis
Copy link

We're getting ready to submit the final report to DARPA. It'd be so nice if this actually saw the light of day ...

@streichler
Copy link
Contributor

It looks like the ball is in @dycz0fx 's court right now?

@elliottslaughter
Copy link
Contributor

@dycz0fx is not working on this anymore, but we will probably pick up the ball here at SLAC/LANL soonish. Maybe not in time for the DARPA report.

We should assign this to @alexaiken and @pmccormick.

@fdouglis
Copy link

Yeah, I wasn't expecting him to do anything other than chime in on the issue you raised with respect to naming. But that isn't essential, you can just proceed.

@dycz0fx
Copy link
Author

dycz0fx commented Sep 12, 2023

One of the key issues (how to test this in CI) looks like it might be more solved than I thought it was. I see there are instructions for running the examples on an AWS node. Are there any other cloud providers that have compatible hardware?

Another issue is the name of the module. I think "fpga" is too generic (e.g. we didn't call the cuda module "gpu"). If this is specific to Xilinx FPGAs (or maybe even a subset of the Xilinx family?), should we have a more specific name? Or is it mostly an OpenCL interface and might work on other device that support OpenCL?

Yeah, FPGA might be too generic. It only works on the Xilinx FPGA with XRT (Xilinx Runtime library) support.
I used the OpenCL extension of the XRT, but I did not try this OpenCL code on other devices that support OpenCL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants