Implement Support for Batch Evaluation #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous work was in the charles/batch-evaluate branch, but the extensive merge conflicts in the SE-generated code made it difficult to rebase onto main. I have manually ported over the changes into this new branch based on main, and have the tests passing again.
Batch evaluation seems to be working with the experimental change I made to the OAS.
srenatus
reviewed
Aug 16, 2024
|
|
||
| # We name the eopa binary opa so that the entrypoint script does not need to be | ||
| # modified. | ||
| COPY --from=ghcr.io/styrainc/enterprise-opa:latest /ko-app/enterprise-opa-private /usr/bin/opa |
There was a problem hiding this comment.
ℹ️ with the next release, this should no longer be necessary. In the mean time, you could use :edge here
There was a problem hiding this comment.
The binary still needs to be copied into the container one way or the other. We can't directly use the eopa container, because we need nginx inside it as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Enterprise OPA's batch evaluation API, including automatic fallback to separate, serial requests when the batch evaluation API is not available. Detection of batch evaluation API support is cached on a per-client basis to avoid repeated attempts to request a nonexistant API endpoint.
This also introduces a new return type,
OPAResult, defers final output type conversion and exception throwing until it's.get()method is called. This allows for mixed success and failure in batch evaluation to be handled gracefully, without losing the outputs from requests which did succeed. A version of the existing, scalar API support has been added to allowOPAResultto also be used in non-batch use cases.Before this PR can be merged, te changes to the OpanAPI spec made to support it have to be merged upstream (#90).