Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Continuous Profiling technical report #12

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

RonakLakhotia
Copy link

Fixes #11

@amrut-prabhu @jacoblipech can you guys take a look at the proposed structure?

Copy link

@amrut-prabhu amrut-prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for all the comments lol. Just my suggestions, doesn't have to be final.

Can you add Authors as well?

Also, I think you should change the issue (and PR) title to Add Continuous Profiling technical report. No point just adding boilerplate

technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
@RonakLakhotia RonakLakhotia changed the title Add boilerplate for technical report Add Continuous Profiling technical report Mar 23, 2019
@amrut-prabhu
Copy link

amrut-prabhu commented Mar 27, 2019

@RonakLakhotia let's plan out the report content here in the project board- first card in the Pinned section.

Let's use that since @jacoblipech and I don't have edit access for this repo... So, we can't edit the PR description to add stuff

Edit: Report is being developed in this Google Doc

technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
@RonakLakhotia
Copy link
Author

@wkurniawan07 can you take a look at this again?

technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
@RonakLakhotia
Copy link
Author

@wkurniawan07 thanks for suggestions. 👍 made requested changes. Ready for review

technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
@RonakLakhotia
Copy link
Author

@wkurniawan07 updated changes, ready for review

technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
@RonakLakhotia
Copy link
Author

@wkurniawan07 updated!

Copy link
Member

@wkurniawan07 wkurniawan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you should link this page from the technical reports' README page. You can mark the previous scalability test technical report as deprecated.

technical-reports/Performance-Testing.md Outdated Show resolved Hide resolved
@RonakLakhotia
Copy link
Author

RonakLakhotia commented Apr 21, 2019

@wkurniawan07 updated headers, links and marked the previous scalability reports as deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Continuous Profiling technical report
3 participants