Fix/code smells

[CarlosZoft]

 know more

Describe your change:

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Documentation change?

Some minor algorithm fixes

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new JavaScript files are placed inside an existing directory.
• All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
  Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
• All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
• If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

[appgurueu]

Definitely an improvement overall. I have some minor comments.

[CarlosZoft]

Ohh nice, tks for review. i'll fix this today xD

[CarlosZoft]

@appgurueu, sorry for the delay, fixed the issues ✅

[badr222222]

I think the data base was mest up at first but think if there was a few of us we can do it

[badr222222]

23 changes: 12 additions & 11 deletions 23
Sorts/SimplifiedWiggleSort.js
Viewed

@@ -8,29 +8,30 @@
import { quickSelectSearch } from '../Search/QuickSelectSearch.js'

export const simplifiedWiggleSort = function (arr) {
const arrSize = arr.length
CarlosZoft marked this conversation as resolved.
// find Median using QuickSelect
let median = quickSelectSearch(arr, Math.floor(arr.length / 2.0))
median = median[Math.floor(arr.length / 2.0)]
let median = quickSelectSearch(arr, Math.floor(arrSize / 2.0))
median = median[Math.floor(arrSize / 2.0)]

const sorted = new Array(arr.length)
const sorted = new Array(arrSize)

let smallerThanMedianIndx = 0
let greaterThanMedianIndx = arr.length - 1 - (arr.length % 2)
let greaterThanMedianIndx = arrSize - 1 - (arrSize % 2)

for (let i = 0; i < arr.length; i++) {
if (arr[i] > median) {
sorted[greaterThanMedianIndx] = arr[i]
arr.forEach(element => {
if (element > median) {
sorted[greaterThanMedianIndx] = element
greaterThanMedianIndx -= 2
} else {
if (smallerThanMedianIndx < arr.length) {
sorted[smallerThanMedianIndx] = arr[i]
if (smallerThanMedianIndx < arrSize) {
sorted[smallerThanMedianIndx] = element
smallerThanMedianIndx += 2
} else {
sorted[greaterThanMedianIndx] = arr[i]
sorted[greaterThanMedianIndx] = element
greaterThanMedianIndx -= 2
}
}
}
})

return sorted
}
2 changes: 1 addition & 1 deletion 2
String/CheckRearrangePalindrome.js
Viewed

@@ -12,7 +12,7 @@ export const palindromeRearranging = (str) => {
return 'Not a string'
}
// Check if is a empty string
if (str.length === 0) {
if (!str) {
return 'Empty string'
}

Use this