feat: Implement Tox network profiler #1885

JFreegman · 2022-01-14T17:57:21Z

This change is

toxcore/net_profile.c

toxcore/net_profile.h

toxcore/TCP_client.h

toxcore/tox_private.h

codecov · 2022-01-15T00:13:44Z

Codecov Report

Attention: Patch coverage is 70.05348% with 56 lines in your changes missing coverage. Please review.

Project coverage is 72.99%. Comparing base (102a1fa) to head (e740b4e).
Report is 6 commits behind head on master.

Files with missing lines	Patch %	Lines
toxcore/tox_private.c	57.40%	46 Missing ⚠️
toxcore/net_profile.c	90.69%	4 Missing ⚠️
toxcore/TCP_connection.c	71.42%	2 Missing ⚠️
toxcore/net_crypto.c	66.66%	2 Missing ⚠️
toxcore/TCP_server.c	83.33%	1 Missing ⚠️
toxcore/network.c	88.88%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1885      +/-   ##
==========================================
- Coverage   73.08%   72.99%   -0.09%     
==========================================
  Files         149      150       +1     
  Lines       30531    30714     +183     
==========================================
+ Hits        22313    22420     +107     
- Misses       8218     8294      +76

Flag	Coverage Δ
	`72.99% <70.05%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

iphydf

Reviewed 10 of 19 files at r1, 8 of 9 files at r2, all commit messages.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @JFreegman)

toxcore/tox_private.h, line 60 at r1 (raw file):

Previously, JFreegman wrote…

The reason I named it ZERO is because it has a different purpose depending on the packet type (see the above comment). Any suggestions?

Ok, that's fine then.

iphydf

Reviewed 1 of 19 files at r1.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @JFreegman)

toxcore/BUILD.bazel

Green-Sky

For testing, we should be able to inject a custom struct Network and compare total packet numbers there.

Green-Sky · 2024-09-21T14:42:55Z

auto_tests/netprof_test.c

+                            TOX_NETPROF_DIRECTION_RECV);
+    }
+
+    const unsigned long long total_packets = total_sent_count + total_recv_count;


generally prefer size named types like uint64_t over unsigned long long.

Green-Sky · 2024-09-21T14:55:44Z

toxcore/tox.c

@@ -18,6 +18,7 @@
 #include "DHT.h"
 #include "Messenger.h"
 #include "TCP_client.h"
+#include "TCP_server.h"


is this right?

Green-Sky · 2024-09-21T15:00:36Z

toxcore/TCP_client.c

@@ -20,6 +20,7 @@
 #include "logger.h"
 #include "mem.h"
 #include "mono_time.h"
+#include "net_profile.h"


Some places, like here, don't need to know the full type and a forward declaration instead would suffice.

Green-Sky · 2024-09-21T15:00:48Z

toxcore/TCP_client.h

@@ -15,6 +15,7 @@
 #include "logger.h"
 #include "mem.h"
 #include "mono_time.h"
+#include "net_profile.h"


Green-Sky · 2024-09-21T15:01:04Z

toxcore/TCP_common.h

@@ -10,6 +10,7 @@
 #include "crypto_core.h"
 #include "logger.h"
 #include "mem.h"
+#include "net_profile.h"


and here. (we only store a pointer)

Green-Sky · 2024-09-21T15:04:14Z

toxcore/TCP_server.h

@@ -15,6 +15,7 @@
 #include "logger.h"
 #include "mem.h"
 #include "mono_time.h"
+#include "net_profile.h"


Green-Sky · 2024-09-21T15:05:13Z

toxcore/net_crypto.h

@@ -20,6 +20,7 @@
 #include "logger.h"
 #include "mem.h"
 #include "mono_time.h"
+#include "net_profile.h"


here too ... i feel like we should forward declare it in some public places.

Green-Sky · 2024-09-21T15:12:43Z

toxcore/network.c

@@ -999,6 +1008,11 @@ int send_packet(const Networking_Core *net, const IP_Port *ip_port, Packet packe
    loglogdata(net->log, "O=>", packet.data, packet.length, ip_port, res);

    assert(res <= INT_MAX);
+
+    if (res == packet.length) {


i saw a data != nullptr earlier, should it be put everywhere, like here too?

Green-Sky · 2024-09-21T15:24:13Z

toxcore/tox_private.h

+     * Bootstrap info packet.
+     */
+    TOX_NETPROF_PACKET_ID_BOOTSTRAP_INFO       = 0xf0,
+} Tox_Netprof_Packet_Id;


all public facing enums in toxcore now have a *_to_string() function. Since there are alot of values here, it would be very valuable.
Maybe it can also take in the type (tcp/udp), to print a sensible string? or maybe I am just dreaming here...

Green-Sky · 2024-09-22T10:55:42Z

toxcore/tox_private.h

+ * @param direction The packet direction.
+ */
+uint64_t tox_netprof_get_packet_total_count(const Tox *tox, Tox_Netprof_Packet_Type type,
+        Tox_Netprof_Direction direction);


missing new line here and the 2 decls below.

Green-Sky · 2024-09-22T12:18:18Z

I get a lot of 0x10 udp packets, which are

    /**
     * TCP data packet.
     */
    TOX_NETPROF_PACKET_ID_TCP_DATA             = 0x10,

supposed to be tcp according to your code.

Green-Sky · 2024-09-22T12:31:13Z

example table

Green-Sky · 2024-09-23T13:47:51Z

The beating heath of a toxcore:

tomato_netprof_tableheat2.mp4

JFreegman added the enhancement New feature for the user, not a new feature for build script label Jan 14, 2022

JFreegman added this to the v0.2.x milestone Jan 14, 2022

restyled-io bot mentioned this pull request Jan 14, 2022

Restyle feat: Implement Tox network profiler #1886

Closed

JFreegman force-pushed the netprof branch 11 times, most recently from b93009f to 75fd324 Compare January 14, 2022 20:13

iphydf requested changes Jan 14, 2022

View reviewed changes

pull-request-attention bot assigned JFreegman and iphydf and unassigned JFreegman Jan 14, 2022

JFreegman force-pushed the netprof branch 7 times, most recently from 84ab794 to 687d5b5 Compare January 15, 2022 00:07

iphydf approved these changes Jan 15, 2022

View reviewed changes

pull-request-attention bot assigned JFreegman and unassigned iphydf Jan 15, 2022

iphydf reviewed Jan 15, 2022

View reviewed changes

JFreegman force-pushed the netprof branch 4 times, most recently from 5c80003 to 5d3e91a Compare February 12, 2024 16:18

Green-Sky reviewed Feb 12, 2024

View reviewed changes

toxcore/BUILD.bazel Outdated Show resolved Hide resolved

pull-request-attention bot assigned JFreegman, Green-Sky and iphydf and unassigned JFreegman and iphydf Feb 12, 2024

JFreegman force-pushed the netprof branch 2 times, most recently from 7852d0b to a53b5b7 Compare February 28, 2024 15:58

JFreegman force-pushed the netprof branch 2 times, most recently from 39a7571 to f1bc5a4 Compare March 7, 2024 18:30

JFreegman force-pushed the netprof branch from f1bc5a4 to 5894cfb Compare March 28, 2024 01:49

JFreegman force-pushed the netprof branch 3 times, most recently from 5700751 to 53d50e4 Compare September 21, 2024 15:09

Green-Sky requested changes Sep 21, 2024

View reviewed changes

pull-request-attention bot assigned JFreegman and unassigned Green-Sky Sep 21, 2024

JFreegman force-pushed the netprof branch from 53d50e4 to 3972670 Compare September 21, 2024 16:36

feat: Implement Tox network profiler

e740b4e

JFreegman force-pushed the netprof branch from 3972670 to e740b4e Compare September 21, 2024 17:15

Green-Sky reviewed Sep 22, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Implement Tox network profiler #1885

feat: Implement Tox network profiler #1885

JFreegman commented Jan 14, 2022 •

edited by iphydf

Loading

codecov bot commented Jan 15, 2022 •

edited

Loading

iphydf left a comment

iphydf left a comment

Green-Sky left a comment

Green-Sky Sep 21, 2024

Green-Sky Sep 21, 2024

Green-Sky Sep 21, 2024

Green-Sky Sep 21, 2024

Green-Sky Sep 21, 2024

Green-Sky Sep 21, 2024

Green-Sky Sep 21, 2024

Green-Sky Sep 21, 2024

Green-Sky Sep 21, 2024

Green-Sky Sep 22, 2024

Green-Sky commented Sep 22, 2024

Green-Sky commented Sep 22, 2024

Green-Sky commented Sep 23, 2024

feat: Implement Tox network profiler #1885

Are you sure you want to change the base?

feat: Implement Tox network profiler #1885

Conversation

JFreegman commented Jan 14, 2022 • edited by iphydf Loading

codecov bot commented Jan 15, 2022 • edited Loading

Codecov Report

iphydf left a comment

Choose a reason for hiding this comment

iphydf left a comment

Choose a reason for hiding this comment

Green-Sky left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Green-Sky commented Sep 22, 2024

Green-Sky commented Sep 22, 2024

Green-Sky commented Sep 23, 2024

JFreegman commented Jan 14, 2022 •

edited by iphydf

Loading

codecov bot commented Jan 15, 2022 •

edited

Loading