-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partitioner - to fix error if partitions have size 1 #1499
Conversation
Signed-off-by: Margaret Duff <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some comments explaining the new unit tests, but otherwise it looks good!
Co-authored-by: Gemma Fardell <[email protected]> Signed-off-by: Margaret Duff <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added just some pedantic suggestions.
Please write "closes #1464" in the text.
Co-authored-by: Edoardo Pasca <[email protected]> Signed-off-by: Margaret Duff <[email protected]>
Co-authored-by: Edoardo Pasca <[email protected]> Signed-off-by: Margaret Duff <[email protected]>
Co-authored-by: Edoardo Pasca <[email protected]> Signed-off-by: Margaret Duff <[email protected]>
Describe your changes
Fixed issue and added a new unit-test
Describe any testing you have performed
Now works:
Link relevant issues
closes #1464
Checklist when you are ready to request a review
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.