Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partitioner - to fix error if partitions have size 1 #1499

Merged
merged 10 commits into from
Sep 22, 2023

Conversation

MargaretDuff
Copy link
Member

@MargaretDuff MargaretDuff commented Aug 17, 2023

Describe your changes

Fixed issue and added a new unit-test

Describe any testing you have performed

Now works:
image

Link relevant issues

closes #1464

Checklist when you are ready to request a review

  • I have performed a self-review of my code
  • [X ] I have added docstrings in line with the guidance in the developer guide
  • [X ] I have implemented unit tests that cover any new or modified functionality
  • [ X] CHANGELOG.md has been updated with any functionality change
  • [X ] Request review from all relevant developers
  • [X ] Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • [ X] The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License.
  • [ X] I confirm that the contribution does not violate any intellectual property rights of third parties

@MargaretDuff MargaretDuff marked this pull request as ready for review August 18, 2023 08:25
Copy link
Member

@gfardell gfardell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some comments explaining the new unit tests, but otherwise it looks good!

@MargaretDuff MargaretDuff added Merge pending jenkins Once jenkins is happy with can be merged and removed Waiting for review labels Aug 30, 2023
@gfardell
Copy link
Member

If you write "closes #1464" or "fixes #1464" in the PR linked issues it'll close the issue automatically when the PR is merged.

Copy link
Contributor

@paskino paskino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added just some pedantic suggestions.

Please write "closes #1464" in the text.

Wrappers/Python/cil/framework/framework.py Outdated Show resolved Hide resolved
Wrappers/Python/cil/framework/framework.py Outdated Show resolved Hide resolved
Wrappers/Python/cil/framework/framework.py Outdated Show resolved Hide resolved
MargaretDuff and others added 3 commits September 21, 2023 10:28
Co-authored-by: Edoardo Pasca <[email protected]>
Signed-off-by: Margaret Duff <[email protected]>
Co-authored-by: Edoardo Pasca <[email protected]>
Signed-off-by: Margaret Duff <[email protected]>
Co-authored-by: Edoardo Pasca <[email protected]>
Signed-off-by: Margaret Duff <[email protected]>
@paskino paskino merged commit a6ce31c into TomographicImaging:master Sep 22, 2023
3 checks passed
@MargaretDuff MargaretDuff deleted the partitioner branch September 28, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge pending jenkins Once jenkins is happy with can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AcquisitionData.partition() ValueError if partitions have size of 1
3 participants