CGLS: deprecate tolerance #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MargaretDuff
changed the title
MargaretDuff
changed the title
gfardell
reviewed
Aug 19, 2024
jakobsj
requested changes
Aug 20, 2024
jakobsj
approved these changes
Aug 21, 2024
MargaretDuff
added
the
Merge pending jenkins
|
Jenkins is happy
|
casperdcl
reviewed
Sep 3, 2024
Comment on lines
+139
to
+152
| class EarlyStoppingObjectiveValue(Callback): | ||
| '''Callback that stops iterations if the change in the objective value is less than a provided threshold value. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| threshold: float, default 1e-6 | ||
|
|
||
| Note | ||
| ----- | ||
| This callback only compares the last two calculated objective values. If `update_objective_interval` is greater than 1, the objective value is not calculated at each iteration (which is the default behaviour), only every `update_objective_interval` iterations. | ||
|
|
||
| ''' | ||
| def __init__(self, threshold=1e-6): | ||
| self.threshold=threshold |
There was a problem hiding this comment.
VERY strongly disapprove of this. Far superior naming, vis. https://keras.io/api/callbacks/early_stopping/:
EarlyStopping,EarlyStoppingObjectiveDelta,EarlyStoppingObjectiveDelta,EarlyStoppingObjectiveChangedelta,change
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
toleranceas a kwarg here to keep backwards compatibility if users have a custom tolerance with a plan to deprecate this fully in a later version.Testing you performed
Related issues/links
Closes #1891, closes #1894
Checklist
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.