build cilacc.dll as release

[gfardell]

Changes

Added:
--config RelWithDebInfo

specified the generator and toolkit in the windows build script to keep consistency between builders.

OUTDATED
Need to build the shared library as 'Release'. Previous build 'RelWithDebug' requires debug dlls which are not included in the VC redistributable installed in the conda environment.

Built as 'RelWithDebug':

Dependencies:
Success: ippcore.dll, Version: 2021,12,0,1052
Success: ipps.dll, Version: 2021,12,0,1087
Success: ippi.dll, Version: 2021,12,0,1083
Failure: VCOMP140D.DLL, Error: DLL not found
Failure: VCRUNTIME140D.dll, Error: DLL not found
Failure: ucrtbased.dll, Error: DLL not found
Success: KERNEL32.dll, Version: 10.0.19041.4717 (WinBuild.160101.0800)

Testing you performed

Please add any demo scripts to https://github.com/TomographicImaging/CIL-Demos/tree/main/misc
Built and tested on windows. Confirmed dll dependencies in conda environments.

Related issues/links

Needed to address for #1880

Checklist

• I have performed a self-review of my code
• I have added docstrings in line with the guidance in the developer guide
• I have updated the relevant documentation
• I have implemented unit tests that cover any new or modified functionality
• CHANGELOG.md has been updated with any functionality change
• Request review from all relevant developers
• Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

• The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License
• I confirm that the contribution does not violate any intellectual property rights of third parties

[casperdcl]

sad... Ideally adding windows debug libs to conda would be better.

[gfardell]

sad... Ideally adding windows debug libs to conda would be better.

As far as I know they are not included the redistributable folder and therefore license so I'm not sure we could. I don't see what we lose with this. Anyone needing to debug should be able to build whichever they want locally.

[paskino]

The CMAKE_BUILD_TYPE has no effect with visual compilers such as VS. At compile time you need to pass the --config RelWithDebInfo. CMake Docs read that CMAKE_BUILD_TYPE

Specifies the build type on single-configuration generators (e.g. Makefile Generators or Ninja).

If I'm not mistaken the default configuration of VS is Debug not RelWithDebInfo.

[gfardell]

Hmm I'm mostly sure I looked at the dependencies with --config RelWithDebInfo but not 100% now....

[gfardell]

@paskino you are correct, RelWithDebInfo doesn't link against the debug libraries. It was defaulting to the debug build before. I'll revert the changes from RelWithDebInfo and keep --config RelWithDebInfo.

Building:

Building Custom Rule C:/Users/gemst/GitHub/CIL/CMakeLists.txt
  -- Install configuration: "RelWithDebInfo"
  -- Installing: C:/Users/gemst/miniforge3/envs/cil_test_fd/Library/bin/cilacc.dll

Path of loaded dll:

>>> path_dll = find_dll(dll_name)
>>> path_dll
'C:\\Users\\gemst\\miniforge3\\envs\\cil_test_fd\\Library\\bin\\cilacc.dll'

Dependencies of loaded dll:

Success: VCOMP140.DLL, Version: 14.40.33810.0
Success: VCRUNTIME140.dll, Version: 14.40.33810.0
Success: api-ms-win-crt-heap-l1-1-0.dll, Version: 10.0.22621.1 (WinBuild.160101.0800)
Success: api-ms-win-crt-stdio-l1-1-0.dll, Version: 10.0.22621.1 (WinBuild.160101.0800)
Success: api-ms-win-crt-runtime-l1-1-0.dll, Version: 10.0.22621.1 (WinBuild.160101.0800)
Success: KERNEL32.dll, Version: 10.0.22621.3374 (WinBuild.160101.0800)

[casperdcl]

yay