-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/leo3friedman/frontend modals #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good. Can we hook up the one Sitting modal and the Requirements not met modal. So that things are connected.
@@ -11,6 +11,7 @@ export type ApplicationProps = { | |||
|
|||
export const Application: React.FC<ApplicationProps> = ({ path }: ApplicationProps) => { | |||
const [pageNum, setPageNum] = useState<0 | 1 | 2 | 3 | 4 | 5>(0); | |||
const [isCompleteInOneSittingModalOpen, setIsCompleteInOneSittingModalOpen] = useState(true); | |||
|
|||
const next = () => { | |||
if (pageNum < 5) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also trigger the Confirm Submission Modal by checking is pageNum is in state 5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Tracking Info
Resolves #46
Changes
Created modal component, Reimplemented congratulations modal, added requirements not met modal, complete in one sitting modal, and confirm submission modal.
Testing
Manual testing
Confirmation of Change