Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/leo3friedman/frontend modals #49

Merged
merged 9 commits into from
May 23, 2024

Conversation

leo3friedman
Copy link
Contributor

Tracking Info

Resolves #46

Changes

Created modal component, Reimplemented congratulations modal, added requirements not met modal, complete in one sitting modal, and confirm submission modal.

Testing

Manual testing

Confirmation of Change

image image image image

Copy link
Member

@Miyuki-L Miyuki-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. Can we hook up the one Sitting modal and the Requirements not met modal. So that things are connected.

frontend/src/components/Modal.tsx Outdated Show resolved Hide resolved
frontend/src/components/Modal.tsx Show resolved Hide resolved
frontend/src/components/Modal.tsx Show resolved Hide resolved
@@ -11,6 +11,7 @@ export type ApplicationProps = {

export const Application: React.FC<ApplicationProps> = ({ path }: ApplicationProps) => {
const [pageNum, setPageNum] = useState<0 | 1 | 2 | 3 | 4 | 5>(0);
const [isCompleteInOneSittingModalOpen, setIsCompleteInOneSittingModalOpen] = useState(true);

const next = () => {
if (pageNum < 5) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also trigger the Confirm Submission Modal by checking is pageNum is in state 5.

Copy link
Contributor

@jaredsbt jaredsbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Miyuki-L Miyuki-L merged commit b9ad5e7 into main May 23, 2024
2 checks passed
@Miyuki-L Miyuki-L deleted the feature/leo3friedman/frontend-modals branch May 23, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend Modals
3 participants