Feature/leo3friedman/dropdown keyboard interactable #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miyuki-L
reviewed
Jun 4, 2024
There was a problem hiding this comment.
Some CSS rule was removed that made the fields that impacted the flexing of elements when the screen is small.
Used to look like this
| <select | ||
| className={`${styles.select} ${selected === defaultSelected ? styles.unselected : ""}`} | ||
| onChange={onSelectChange} | ||
| required={required} |
There was a problem hiding this comment.
smll thing; can we add a name attribute to this that could be passed in through the props?
kathyychenn
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking Info
Resolves #56
Changed Dropdown to use select element
Removed unnecessary inputs
Testing
Manual testing
Confirmation of Change