Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route to get all student information #53

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Route to get all student information #53

merged 3 commits into from
Feb 22, 2024

Conversation

parth4apple
Copy link
Member

@parth4apple parth4apple commented Feb 7, 2024 •
edited
Loading

Tracking Info

Resolves #29

Changes

  • made a route to get all student information, gets rid of some keep files
  • note that this doesn't use auth
  • note that the change in handler.js is to get rid of the issue in the image below which kept occurring every time a route was called (as per this fix)
Screenshot 2024-02-07 at 1 05 37 AM

Testing

  • can call it at "/api/student/all"

adhi0331
adhi0331 approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@adhi0331 adhi0331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! 🚀

@aaronchan32 aaronchan32 mentioned this pull request Feb 17, 2024
Closed
@github-actions GitHub Actions
Copy link

Visit the preview URL for this PR (updated for commit 7a5d338):

https://pia-dev-60cea--pr53-feature-parth4apple-hvdptd53.web.app

(expires Tue, 27 Feb 2024 10:50:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b780ee12a240535f7ca0729d49968573a1f3e284

aaronchan32
aaronchan32 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@aaronchan32 aaronchan32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@adhi0331 adhi0331 merged commit d329059 into main Feb 22, 2024
4 checks passed
@adhi0331 adhi0331 deleted the feature/parth4apple/get-students-route branch February 22, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronchan32 aaronchan32 aaronchan32 approved these changes

@adhi0331 adhi0331 adhi0331 approved these changes

@mraysu mraysu Awaiting requested review from mraysu

@vs2961 vs2961 Awaiting requested review from vs2961

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[All Students Page] - Create a backend route to get all student information
3 participants
@parth4apple @aaronchan32 @adhi0331