Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOWTO Readme for printing out #309

Merged
merged 6 commits into from
Nov 9, 2023
Merged

HOWTO Readme for printing out #309

merged 6 commits into from
Nov 9, 2023

Conversation

ateRstones
Copy link
Collaborator

@ateRstones ateRstones commented Nov 1, 2023

I started a HOWTO file to print and add to the box of parts.

Please extend as you see fit.

Especially the rqt part (as I don't know about it)

I copied most of the parts from other readmes

@yl-wang996
Copy link
Collaborator

We can also do/talk about this on Friday.

@Juphex
Copy link
Member

Juphex commented Nov 3, 2023

Could you please add documentation on how to calibrate the position of the marimba? :)

@Flova
Copy link
Collaborator

Flova commented Nov 4, 2023

And also how you can grab the mallet holder with rviz using the gripper

@ateRstones
Copy link
Collaborator Author

And also how you can grab the mallet holder with rviz using the gripper

I added something about this in the hardware setup part. Do you think it should be changed?

@ateRstones
Copy link
Collaborator Author

Could you please add documentation on how to calibrate the position of the marimba? :)

I added some steps for this, please check if they are correct

update the visualization and setup the microphone
@yl-wang996
Copy link
Collaborator

yl-wang996 commented Nov 9, 2023

I uploaded the section about how to set up the microphone and how to open visualization. please check if something else is missing.

@Flova
Copy link
Collaborator

Flova commented Nov 9, 2023

I fixed some spelling errors and reworked the overall structure, so it makes more sense for somebody who wants to get the system up and running. Especially some hardware that were explained separately in the end were required by software that was started in the beginning, so I interlaced it a little bit. Now, following the guide step by step should work. I also changed the calibration a bit.

Copy link
Collaborator

@yl-wang996 yl-wang996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Flova Flova merged commit 02b539a into main Nov 9, 2023
2 checks passed
@Flova Flova deleted the doc/howto branch November 9, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants