adding some unit tests, also noting some todo locations to respond to…

… nick comments

lifeloss/lifeloss.go

@@ -54,7 +54,7 @@ func Init(seed int64, warningSystem warning.WarningResponseSystem) LifeLossEngin
 }
 
 func LifeLossHeader() []string {
-	return []string{"ll_u65", "ll_o65", "ll_tot"}
+	return []string{"ll_u65", "ll_o65", "ll_tot"} //@TODO: Consider adding structure stability state, fatality rates, and sampled hazard parameters
 }
 func LifeLossDefaultResults() []interface{} {
 	var ll_u65, ll_o65, ll_tot int32
@@ -89,7 +89,7 @@ func (le LifeLossEngine) ComputeLifeLoss(e hazards.HazardEvent, s structures.Str
 		} else {
 			return le.submergenceCriteria(e, s, remainingPop, rng)
 		}
-	} else {
+	} else { //@TODO:ensure i have depth at least!!!
 		//apply submergence criteria
 		return le.submergenceCriteria(e, s, remainingPop, rng)
 	}

lifeloss/stability_test.go

@@ -0,0 +1,72 @@
+package lifeloss
+
+import (
+	"testing"
+
+	"github.com/USACE/go-consequences/hazards"
+)
+
+func Test_RescDamUnanchoredWoodStability(t *testing.T) {
+
+	sc := RescDamWoodUnanchored
+
+	h := hazards.DepthandDVEvent{}
+	h.SetDV(30)
+	h.SetDepth(100)
+	result := sc.Evaluate(h)
+	if result != Stable {
+		t.Fail()
+	}
+
+	h.SetDV(35)
+	h.SetDepth(100)
+	result = sc.Evaluate(h)
+	if result != Collapsed {
+		t.Fail()
+	}
+}
+func Test_RescDamAnchoredWoodStability(t *testing.T) {
+
+	sc := RescDamWoodAnchored
+
+	h := hazards.DepthandDVEvent{}
+	h.SetDV(35)
+	h.SetDepth(100)
+	result := sc.Evaluate(h)
+	if result != Stable {
+		t.Fail()
+	}
+
+	h.SetDV(75.4)
+	h.SetDepth(100)
+	result = sc.Evaluate(h)
+	if result != Collapsed {
+		t.Fail()
+	}
+}
+func Test_RescDamConcreteMasonarySteelStability(t *testing.T) {
+
+	sc := RescDamMasonryConcreteBrick
+
+	h := hazards.DepthandDVEvent{}
+	h.SetDV(35)
+	h.SetDepth(100)
+	result := sc.Evaluate(h)
+	if result != Stable {
+		t.Fail()
+	}
+
+	h.SetDV(75.4)
+	h.SetDepth(10)
+	result = sc.Evaluate(h)
+	if result != Collapsed {
+		t.Fail()
+	}
+
+	h.SetDV(75.4)
+	h.SetDepth(20)
+	result = sc.Evaluate(h)
+	if result != Stable { //velocity is computed as not being high enough because depth was so high.
+		t.Fail()
+	}
+}

warning/warningresponse.go

@@ -21,7 +21,7 @@ type ComplianceBasedWarningSystem struct {
 func InitComplianceBasedWarningSystem(seed int64, complianceRate float64) ComplianceBasedWarningSystem {
 	return ComplianceBasedWarningSystem{rng: rand.New(rand.NewSource(seed)), ComplianceRate: complianceRate}
 }
-func (c ComplianceBasedWarningSystem) WarningFunction() PopulationReductionFunction {
+func (c ComplianceBasedWarningSystem) WarningFunction() PopulationReductionFunction { //@TODO:Consider housing groups instead of simply assuming each individual is independent
 	return func(s structures.StructureDeterministic, hazard hazards.HazardEvent) (structures.PopulationSet, consequences.Result) {
 		pop2amo65 := 0
 		pop2amu65 := 0