Generate PL URLs for Diffy Visual Regression testing #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dcmouyard Please take a look at this locally since the Github diff viewer can't handle the size of the package-lock.json diff. I had to add a couple of npm packages and it made a large number of changes to the lock file for reasons I'm not entirely clear about. It even changed the lockfileVersion property from 2 to 1 which to me implies I generated this using a different version of npm than you were using. To be clear, I'm running npm commands through ddev like: |
|
@dcmouyard Please take a look at this when you get a chance. I'd love to get this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.