[MIG] account_chatter: migration to 17.0 #1640
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n community addons
* Adds better description and docstring to account_account methods * Add security group to show account_account notifications
Images in the README file now point to the ones located in the module, and docstring was improved to explaing why manual tracking is required.
Migration standard
This reverts commit a7e4b8c. The "hidden" category is used for thechnical groups (the ones enabled/disabled for all users), which is not the case for the account chatter group.
* Change category group to avoid conflicts with account group <img width="880" alt="Screen Shot 2021-09-16 at 11 06 09 PM" src="https://user-images.githubusercontent.com/16024775/133727633-83798393-6c92-40b0-9933-ab560faa11a8.png"> <img width="930" alt="Screen Shot 2021-09-16 at 11 13 25 PM" src="https://user-images.githubusercontent.com/16024775/133728255-e83fcf01-1788-48a5-b247-19def7d3801d.png">
- Add tracking to allowed_journal_ids field in account.account model.
- This change is because in 15.0 the account.account model has tracking to some fields, so is not necessary the mail.thread inherit and overwrite the fields to add tracking.
- Add admin and root users as default on the group `group_show_account_chatter_notifications`.
To be able to show chatter only to certain users, we: - Hide chatter for everywhere by removing it - Re-introduce it only for the specific group However, the new chatter is missing the activity widget, which was already present on the removed one. This atts missing activity widget to journal and journal entries, and improve accounts by adding it also there. In addition, journal entry's chatter was being placed on a wrong position, before attachments preview instead of after it.
group - Show account.account chatter only for the group "group_show_account_chatter_notifications"
Even though an initial migration was already performed, module was still not working. Code was re-written to be cleaner and less intrusive to the tracking mechanism.
- W7902(duplicate-xml-record-id).
Python headers were removed from python files
Due to the inability to add groups to inherited views in v16, the views in this module were refactored so they would still function as intended
… text This module reassigns the narration field type, from html to text, that was wrong because when the field being refereced from a related field following error appears TypeError: Type of related field bank.rec.widget.st_line_narration is inconsistent with account.move.narration So we remove the field inheritance, because the only reason this field was inherited was to make it trackeable, which is not supported for HTML fields.
This commit adds tracking to several fields across the `account_account`, `account_journal`, and `account_move` models. In `account_account`, tracking was added to the `non_trade` field. In `account_journal`, tracking was added to `account_control_ids`, `refund_sequence`, and `restrict_mode_hash_table` fields. In `account_move`, tracking was added to `company_id`, `fiscal_position_id`, `auto_post`, and `auto_post_until` fields. These changes will help keep a better record of modifications to these fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.