This repository has been archived by the owner on Aug 16, 2023. It is now read-only.
[IMP] odoo-shippable: Load .bash_aliases at the end of .bashrc #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er-defined aliases aren't overridden
|
I should note that, even though Travis tests are not passing, that issue is not related to my modifications and it comes from before, as reported on #214 |
|
@moylop260 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the Docker image
docker-odoo-imageis built up, all modifications to the file.bashrcare appended at the end of the file.Even though this behavior works just fine in most cases, it also overrides possible-user-defined settings on the file
~/.bash_aliases, because that file is loaded before all modifications, thus making image settings taking precedence over user-defined settings.This change re-locates the inclusion of
.bash_aliasesat the end of~/.bashrc, so all settings and aliases defined on.bash_aliasesare not overridden anymore.