✨ DynamicArrayLib #1073
Merged
✨ DynamicArrayLib #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atarpara
reviewed
Sep 14, 2024
atarpara
reviewed
Sep 14, 2024
src/utils/DynamicArrayLib.sol
Outdated
| let cap := mload(add(arrData, w)) // `mload(sub(arrData, w))`. | ||
| // Extract `cap`, initializing it to zero if it is not a multiple of `prime`. | ||
| cap := mul(div(cap, prime), iszero(mod(cap, prime))) | ||
| let newCap := shl(5, add(1, minimum)) |
There was a problem hiding this comment.
Why reserving 1 extra slot?
There was a problem hiding this comment.
Cuz:
// Expand / Reallocate memory if required.
// Note that we need to allocate an extra word for the length.
for {} iszero(lt(newArrBytesLen, cap)) {} {is more efficient than
// Expand / Reallocate memory if required.
// Note that we need to allocate an extra word for the length.
for {} gt(newArrBytesLen, cap) {} {
atarpara
force-pushed
the
dynamicarraylib
branch
from
6d7b1dd
to
24d0072
Compare
|
If we add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
✨
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge fmt?forge snapshot?forge test?Pull requests with an incomplete checklist will be thrown out.