Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Minimal Pod #1087

Merged
merged 4 commits into from
Sep 19, 2024
Merged

✨ Minimal Pod #1087

merged 4 commits into from
Sep 19, 2024

Conversation

atarpara
Copy link
Collaborator

Description

#1086 Completed.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

src/accounts/Pod.sol Outdated Show resolved Hide resolved
@Vectorized
Copy link
Owner

Just recalled, need to add Milady and README too.

Copy link
Owner

@Vectorized Vectorized left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lemme edit the comments a bit.

Copy link

github-actions bot commented Sep 19, 2024

Gas Snapshot Comparison Report

Generated at commit : 2a040f8, Compared to commit : b14edc5

Contract Name Test Name Main Gas PR Gas Diff
DeploylessPredeployQueryerTest testTargetGenerate() 367539 360733 -6806
DynamicArrayLibTest testDynamicArrayPushAfterReserve() 40001 39934 -67
testUint256ArrayPopulate() 17057 - -
testUint256ArrayPopulateOriginal() 22825 - -
test__codesize() 8362 8005 -357
DynamicBufferLibTest testDynamicBufferReserveFromEmpty2() 2429 2441 12
test__codesize() 14832 14840 8
EnumerableSetLibTest testEnumerableUint8Set() 69218 67772 -1446
test__codesize() 16033 16034 1
PodTest testExecute() - 421436 -
testExecuteBatch() - 753927 -
testInitializeMothership() - 10811 -
testSetMothership() - 12776 -
test__codesize() - 11938 -

@Vectorized Vectorized merged commit 74bb616 into main Sep 19, 2024
10 checks passed
@Vectorized Vectorized deleted the pod branch September 19, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants