Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove store validation #509

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove store validation #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions pkg/playbook/app/domain/installation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,10 @@ const (
capiLocationLocalMachine = "localmachine"
)

var validStoreNames = []string{"addressbook", "authroot", "certificateauthority", "disallowed", "my", "root",
"trustedpeople", "trustedpublisher"}
// Recommend removing store validation - this can cause conflicts for scenarios such as SNI:
// https://learn.microsoft.com/en-us/iis/get-started/whats-new-in-iis-8/iis-80-server-name-indication-sni-ssl-scalability
// var validStoreNames = []string{"addressbook", "authroot", "certificateauthority", "disallowed", "my", "root",
// "trustedpeople", "trustedpublisher"}

// Installation represents a location in which a certificate will be installed,
// along with the format in which it will be installed
Expand Down Expand Up @@ -128,17 +130,20 @@ func validateCAPI(installation Installation) error {

// valid store names from https://learn.microsoft.com/en-us/dotnet/api/system.security.cryptography.x509certificates.storename?view=net-7.0
// Although it is unlikely that you'd want to install a certificate and private key in anything but "my", here for completeness
isValidStoreName := false
for _, v := range validStoreNames {
if v == strings.ToLower(segments[1]) {
isValidStoreName = true
break
}
}

if !isValidStoreName {
return ErrInvalidCAPIStoreName
}
// Removing validation check. Web Hosting is a common CAPI store location specifically designed to scale for IIS installations using a large number of certificates:
// https://learn.microsoft.com/en-us/iis/get-started/whats-new-in-iis-8/iis-80-server-name-indication-sni-ssl-scalability
// isValidStoreName := false
// for _, v := range validStoreNames {
// if v == strings.ToLower(segments[1]) {
// isValidStoreName = true
// break
// }
// }

// if !isValidStoreName {
// return ErrInvalidCAPIStoreName
// }

return nil
}
Expand Down
40 changes: 21 additions & 19 deletions pkg/playbook/app/domain/playbook_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,25 +505,27 @@ func (s *PlaybookSuite) SetupTest() {
},
},
},
{
err: ErrInvalidCAPIStoreName,
name: "InvalidCAPIStoreName",
pb: Playbook{
Config: config,
CertificateTasks: CertificateTasks{
CertificateTask{
Name: "testTask",
Request: req,
Installations: Installations{
Installation{
Type: FormatCAPI,
Location: "LocalMachine\\foo",
},
},
},
},
},
},
// Removing to facilitate changes referenced in installation.go:
// https://learn.microsoft.com/en-us/iis/get-started/whats-new-in-iis-8/iis-80-server-name-indication-sni-ssl-scalability
// {
// err: ErrInvalidCAPIStoreName,
// name: "InvalidCAPIStoreName",
// pb: Playbook{
// Config: config,
// CertificateTasks: CertificateTasks{
// CertificateTask{
// Name: "testTask",
// Request: req,
// Installations: Installations{
// Installation{
// Type: FormatCAPI,
// Location: "LocalMachine\\foo",
// },
// },
// },
// },
// },
// },
{
err: nil,
name: "ValidCAPIConfig",
Expand Down