Add Docker secrets support for wsadmin password config #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
This pull requests contains all the changes to set the password for the wsadmin user from a Docker secret, even having the workaround by bind-mounting the
/tmp/PASSWORDand/tmp/passwordupdatedfiles from the host with the desired password.To make this consistent, the environment variable
SECRET_NAMEhas been created to customize the secret management without breaking anything in the service. The script defaults it towsadmin_password.If you have any questions or suggestion please feel free to comment here.
Greetings from Cartagena (Spain).