Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spec] Join and bid counts are UTC based #629

Merged
merged 4 commits into from
Jun 15, 2023
Merged

[Spec] Join and bid counts are UTC based #629

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
44ca70b
[Spec] Join counts are UTC based
caraitto Jun 14, 2023
b878701
Merge branch 'main' of github.com:WICG/turtledove into utc
caraitto Jun 14, 2023
0bfc7ce
Merge branch 'main' of github.com:WICG/turtledove into utc
caraitto Jun 15, 2023
b15cf7e
[Spec] Change more places that mention local time to UTC
caraitto Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,8 @@ This is detectable because it can change the set of fields that are read from th
1. Set |interestGroup|'s [=interest group/joining origin=] to [=this=]'s
[=relevant settings object=]'s [=environment/top-level origin=].
1. If the most recent entry in [=interest group/join counts=] corresponds to
the current local day, increment its count. If not, insert a new entry with
the time set to the current local day and a count of 1.
the current day in UTC, increment its count. If not, insert a new entry with
the time set to the current UTC day and a count of 1.
1. Store |interestGroup| in the browser’s [=interest group set=].
1. Return |p|.

Expand Down Expand Up @@ -2266,12 +2266,12 @@ An interest group is a [=struct=] with the following items:
:: An [=origin=]. The top level page origin from where the interest group was joined.
: <dfn>join counts</dfn>
:: A [=list=] containing [=tuples=] of the day and per day join count. The day
is calculated based on local time. The join count is a count of the number of
is calculated based on UTC time. The join count is a count of the number of
times {{Navigator/joinAdInterestGroup()}} was called for this interest group on the
corresponding day.
: <dfn>bid counts</dfn>
:: A [=list=] containing [=tuples=] of the day and per day bid count. The day
is calculated based on local time. The bid count is a count of the number of
is calculated based on UTC time. The bid count is a count of the number of
times the bid calculated during {{Navigator/runAdAuction()}} was greater than 0.
: <dfn>previous wins</dfn>
:: A [=list=] of [=previous wins=].
Expand Down