Specify base64url encoding for auction result header #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JensenPaul
reviewed
Jun 16, 2023
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jun 16, 2023
Sites using the Ad-Auction-Result header to provide the result from ad auctions may want to provide the results from multiple auctions in a single response. This CL adds support for that and also changes the encoding from base16 to base64url to reduce the header overhead. This implements the changes described in the explainer pull request: WICG/turtledove#631 Bug: 1442274 Change-Id: I046d36aac46b40119a3129adffae26e623e2c6b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614132 Reviewed-by: Yao Xiao <[email protected]> Commit-Queue: Russ Hamilton <[email protected]> Cr-Commit-Position: refs/heads/main@{#1158971}
JensenPaul
added
the
Non-breaking Feature Request
github-actions bot
added a commit
that referenced
this pull request
Jul 27, 2023
SHA: 278a445 Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify the encoding for the auction response and clarify support multiple auction response headers.